Allow Rake task to accept multiple profiles. fixes #905 #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis is reporting a failure for the jruby build, but the error seems to be unrelated (configuration):
|
naively add the profile(s) with the --profile option prepended to each one, still returning potentially nested array
jasonkarns
force-pushed
the
rake-multiple-profiles
branch
from
38f1a74 to
80a55db
Compare
|
Thanks for your contribution @jasonkarns, and I'm sorry it too soooo long to be merged. As part of a new policy, I've given you the commit bit to encourage you to come back and make further contributions! Please give me a shout back on gitter if you'd like any help where to get started. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests around the Rake task were already pretty sparse. So tests against existing behavior were added first, then failing tests for the new array support, and finally implementation (and refactoring of tests/implementation).
Can be squashed if desired.