Fixes the rubocop violation 'Lint/AmbiguousRegexpLiteral' #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
|
Thanks a lot @pmatsinopoulos! 👍 |
pmatsinopoulos
deleted the
fix-style-violations-1021-ambiguous-regexp-literal
branch
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refs: #1021
Fixes the
Lint/AmbiguousRegexpeLilteralrubocop offence.Details
Calls such as
Given /.../ do, having the regular expression literal not wrapped in parentheses are a rubocop violation. They have been turned toGiven(/.../) do. Also, there were some calls to RSpec matchermatchwritten asmatch /.../which have been turned tomatch(/.../).Motivation and Context
Contribute to the process of eliminating the rubocop offending code.
How Has This Been Tested?
I've run all the tests. They are green. There was no need to add new tests.
Screenshots (if appropriate):
N/A
Types of changes
Checklist: