Fix style violations

[nodo]

At the moment, the codebase has several style violations. It would be great to refactor the code, such that we are up to date with the community best practices https://github.com/bbatsov/ruby-style-guide.

The list of the violations is in two files:

• https://github.com/cucumber/cucumber-ruby/blob/master/.rubocop_todo.yml (auto generated)
• https://github.com/cucumber/cucumber-ruby/blob/master/.rubocop.yml

These files specify the ignored violations. It would be great to remove some of the violations from the files and fix them progressively in order to keep the PRs small.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

[xtrasimplicity]

Reopened. :)

[mxygem]

Thanks, @xtrasimplicity !

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

[mxygem]

I will get back to this eventually!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

[mxygem]

Aaaand keeping open again! (Sorry all!)

[mxygem]

32 commits with more fixes have been made. (Many more to come)

[mxygem]

Another 23 commits/cops down!

[mxygem]

I should add that all the auto-correctable cops are now done. The next ones will require some more work and others I'll need to make some style decisions around things like line lengths and complexities. I may just leave the complexity counters where they're at as the repo has some pretty monstrous module/classes in it. Part of that size may simply be necessitated by the work we're doing, and that's a-okay. :)

23 cops left!

[mxygem]

Alrighty! Down to the final 8 cops left in the todo file! These are going to be tough to address as they'll require some serious refactoring to handle.

[mxygem]

With a85672c, I'm calling this issue FINALLY complete! I'll leave it open for a day for feedback/changes.

For some of the limit based cops, I chose a number that would handle the bulk of cases and then either inline disabled some or refactored. There were some scenarios where I wasn't sure how to address them and instead inline disabled. One of the main ones to point out would be setting up a responds_to_method_missing? method here. If anyone wants to take a crack at it or wants to let me know the best way to handle it, feel free. :)

Thanks!

[mxygem]

Turns out that the code changes made aren't suitable for use with older Ruby versions so I need to spend some time fixing that. It's mainly just updating the uses of .match? to use something supported by those versions.

[mxygem]

With @brasmusson 's changes to the match usage, this can now be considered complete! Rubocop has been a part of the rake task for a bit now, so any new development should conform to the rules. If anyone would like to go over the current rubocop file's settings, feel free to reach out or tag me in an issue!

[nodo]

🎉

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.