Refs #1021 - Fixes the rubocop violation 'Style/StringLiterals'

[pmatsinopoulos]

Summary

Fixed the Style/StringLiteral rubocop offending code.

Details

Motivation and Context

This change fix part of #1021. It does not fix it completely, but only partially. Other PRs will follow on same issue.

How Has This Been Tested?

No new tests have been added. But existing tests run green. Also rubocop is happy with the Style/StringLiterals enabled.

Screenshots (if appropriate):

N/A

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Style changes to make rubocop happy.

Checklist:

• I've added tests for my code
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[mattwynne]

@cucumber/cucumber-ruby would any of you like to help merge these in? You all have the appropriate permissions!

[mattwynne]

Thanks a lot @pmatsinopoulos - keep them coming, we appreciate it!

[brasmusson]

@pmatsinopoulos You need to careful when you write the PR description, you used "fix #1021", that is a wording that will trigger Github to automatically close the referred issue when the RP is merged. I changed it to "fix part of #1021" to inhibit Github to do that.

[pmatsinopoulos]

@brasmusson

@pmatsinopoulos You need to careful when you write the PR description

Ooooh! Didn't know that. Sorry. Thanks for letting me know! Will definitely make sure will not happen again.

[mattwynne]

any chance you could rebase this @pmatsinopoulos?

[pmatsinopoulos]

any chance you could rebase this @pmatsinopoulos?

@mattwynne gladly will do that. But will be tomorrow. I am travelling today.

[pmatsinopoulos]

@mattwynne I finally did that a while ago. Conflicts with master have been resolved.

[nodo]

Hi @pmatsinopoulos, I am sorry I have been merging some other PRs about style and now your PR has conflicts again. Please, could you resolve the conflicts and rebase? As soon as you do it I will get it merged.

Thanks a lot for your work, really appreciated.

[pmatsinopoulos]

@nodo Ready. No problem!

[nodo]

Thanks a lot @pmatsinopoulos ! Looks good 👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.