Fix Rubocop violations in the legacy API adapter #1148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
danascheider
force-pushed
the
fix-rubocop-in-legacy-adapter
branch
from
54f1246 to
7f53a04
Compare
danascheider
force-pushed
the
fix-rubocop-in-legacy-adapter
branch
from
7f53a04 to
5da5091
Compare
nodo
requested changes
Jul 12, 2017
There was a problem hiding this comment.
Actually, sorry @danascheider, if I remember correctly in cucumber codebase there is the convention to avoid parenthesis when the result of a method call is discarded. I wanted to write a custom cop for that, I will try to find some time for it.
|
@nodo An issue with precisely these parens missing is that they yield Ruby warnings. Perhaps the convention would opt for no-warnings, when there's no other way? |
|
@nodo "I think", I should add. |
|
Let's not waste any time on the (hopefully soon) to be removed legacy_api, see #1230. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Rubocop violations in the legacy API adapter and reconfigures Rubocop not to ignore this file.
Summary
Removed the legacy API adapter file from the .rubocop-todo.yml file and then fixes the Rubocop violations that occur in that file.
Details
There were two method calls where the args needed to be enclosed in parentheses; I added parens to both.
Types of changes
Checklist: