Remove the legacy_api

[brasmusson]

Summary

Remove the legacy_api.

Details

As soon as all formatter have been re-written to use the new formatter api (see #839), the legacy_api should be removed.

Closes #839.

Motivation and Context

The legacy_api was only intended as a short term fix in v2.0.0.

How Has This Been Tested?

Types of changes

• Refactor (code change that does not change external functionality)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• I've added tests for my code
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[mattwynne]

\o/

@brasmusson how about we set the master branch to target v4.0.0 and try and just rip out all this old code, including the pretty/html formatters, then rebuild from there?

My only concern is that there may be quite a few scenarios that depend on the pretty formatter, though I could be wrong.

[brasmusson]

Around half of the scenarios fail when the pretty and html formatters do not work. A bit less than half if the default formatter is changed to progress, otherwise more than half (137 out of 210) of the scenarios fails. So yes, a lot of our feature files depends on the pretty formatter.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

[olleolleolle]

I’m interested in this being open.

[mattwynne]

💖 hooray!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.