Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes rubocop violation Lint/AmbiguousOperator #1202

Closed
wants to merge 1 commit into from
Closed

Fixes rubocop violation Lint/AmbiguousOperator #1202

wants to merge 1 commit into from

Conversation

aidamanna
Copy link
Contributor

Summary

Fixes rubocop violation Lint/AmbiguousOperator.

Details

Method arguments have been parenthesised when using block operators or splat operators.

Motivation and Context

This change is required to satisfy the ruboxop requirement related to Lint/AmbiguousOperator.
Refs #1021

How Has This Been Tested?

No new tests. Existing tests are green (with bundle exec rake). Rubocop is happy.

Screenshots (if appropriate):

N/A.

Types of changes

  • Refactor (code change that does not change external functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Rubocop fix.

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for a careful change.

@mxygem
Copy link
Member

mxygem commented Oct 26, 2017

Thank you for the work here @aidamanna! I'm sorry to say that you and I aren't the only ones who've done this work but it's unneeded. :( This fix was initially done in #1022 but it was deemed that we wouldn't make these changes. Give the issue a read for more info!

Again, thank you for the work! If you'd like to grab another cop to work on please do. I need to get #1208 merged so that we don't run into this issue again. Sorry!

@mxygem
Copy link
Member

mxygem commented Oct 26, 2017

@aidamanna If you pull down or look at the current code, the rubocop.yml and rubocop_todo.yml files are up to date now!

@mxygem
Copy link
Member

mxygem commented Oct 27, 2017

@aidamanna I've updated master to be up to date now. Go give it a look and pull another style cop to fix? Sorry again that you ended up duplicating work!

@lock
Copy link

lock bot commented Oct 27, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants