Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gemspec/RequiredRubyVersion #1252

Merged
merged 2 commits into from
Jan 22, 2018
Merged

Fix Gemspec/RequiredRubyVersion #1252

merged 2 commits into from
Jan 22, 2018

Conversation

mxygem
Copy link
Member

@mxygem mxygem commented Jan 21, 2018

Details

  • Rubocop likes the ruby version specified to be the same between .rubocop.yml and the required version in the gemspec. Since we hadn't specified a version in the rubocop file, it defaulted to the 2.1 which doesn't equal 2.2. :)

Update the versions and the comments for each. Also had a Lint/UnneededRequireStatement violation pop up that I handled.

Motivation and Context

Working to help solve issue 1021!

How Has This Been Tested?

bundle exec rake 👍

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Rubocop style fixes

@ghost ghost assigned mxygem Jan 21, 2018
olleolleolle
olleolleolle approved these changes Jan 21, 2018
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mxygem mxygem merged commit 48d423d into master Jan 22, 2018
@mxygem mxygem deleted the 1021-required-ruby-version branch January 22, 2018 07:15
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 20, 2018
Closed
@lock
Copy link

lock bot commented Jan 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees

@mxygem mxygem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxygem @olleolleolle