Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Layout/EmptyLinesAroundBlockBody #1263

Merged
merged 4 commits into from
Jan 25, 2018
Merged

Conversation

mxygem
Copy link
Member

@mxygem mxygem commented Jan 24, 2018

Details

  • Removed a bunch of empty lines.
  • Also adjusted json spec tests to continue passing

Motivation and Context

Working to help solve issue 1021!

How Has This Been Tested?

bundle exec rake 👍

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Rubocop style fixes

- Also adjusted json spec tests to continue passing
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for also fixing those line numbers.

LGTM!

@mxygem mxygem merged commit 9804677 into master Jan 25, 2018
@mxygem mxygem deleted the 1021-empty-lines-around-block-body branch January 25, 2018 05:51
@lock
Copy link

lock bot commented Jan 25, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants