Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spacing before comma, in lambda, and array literal brackets #1277

Merged
merged 3 commits into from
Feb 12, 2018

Conversation

mxygem
Copy link
Member

@mxygem mxygem commented Feb 10, 2018

Details

  • Layout/SpaceBeforeComma
  • Layout/SpaceInLambdaLiteral
  • Layout/SpaceInsideArrayLiteralBrackets
  • Fixed with auto and tested

Motivation and Context

Working to help solve issue 1021!

How Has This Been Tested?

bundle exec rake 👍

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Rubocop style fixes

- Layout/SpaceBeforeComma
- Layout/SpaceInLambdaLiteral
- Layout/SpaceInsideArrayLiteralBrackets
- Fixed with auto and tested
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

[:clear, 0],
[:reset, 0], # synonym for :clear
[:bold, 1],
[:dark, 2],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it’s fair to manually fix these spaces inside the lists’ elements here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, can do. thanks for the pointer!

@mxygem mxygem merged commit 95c3513 into master Feb 12, 2018
@mxygem mxygem deleted the 1021-spacework2 branch February 12, 2018 20:37
@lock
Copy link

lock bot commented Feb 12, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants