-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade gherkin and cucumber expressions #1299
Conversation
Curious about why the jruby build failed "to SSH". |
No idea - let's see if your retrigger fixes it |
Yeh was about to say, on any CI environment (Travis/Circle/Jenkins), I've had sporadic failures (probably < 0.1%), for weird build instructions or something that's come through in the wrong order. Just close/reopen and give it a kick. |
Woo! Assuming this passes, can we rebase #1296 and kick off a new release? |
@xtrasimplicity yes I think a new release is overdue! Do you want to handle that? I prefer merging over rebasing :-) https://medium.com/@fredrikmorken/why-you-should-stop-using-git-rebase-5552bee4fed1 |
@aslakhellesoy Awesome! Yep, I can do that. Thanks for the heads up re: merging, and for the link - I'll take a read and will make sure I merge. :) |
With jruby, we're using the alpine image which may not include the git client (given alpine is pretty lightweight), maybe we should move to a circle CI-specific JRuby image? I.e. |
Switched the JRuby image in CircleCI config from the Alpine image to the CircleCI one, which has fixed the CI issues. Will merge once the changelog changes in CI complete! 👍 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Upgrade to latest versions