Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gherkin and cucumber expressions #1299

Merged
merged 3 commits into from
Jun 3, 2018

Conversation

aslakhellesoy
Copy link
Contributor

Upgrade to latest versions

@olleolleolle
Copy link
Contributor

Curious about why the jruby build failed "to SSH".

@aslakhellesoy
Copy link
Contributor Author

No idea - let's see if your retrigger fixes it

@luke-hill
Copy link
Contributor

Yeh was about to say, on any CI environment (Travis/Circle/Jenkins), I've had sporadic failures (probably < 0.1%), for weird build instructions or something that's come through in the wrong order. Just close/reopen and give it a kick.

@xtrasimplicity
Copy link
Member

Woo! Assuming this passes, can we rebase #1296 and kick off a new release?

@aslakhellesoy
Copy link
Contributor Author

@xtrasimplicity yes I think a new release is overdue! Do you want to handle that?

I prefer merging over rebasing :-) https://medium.com/@fredrikmorken/why-you-should-stop-using-git-rebase-5552bee4fed1

@xtrasimplicity
Copy link
Member

@aslakhellesoy Awesome! Yep, I can do that.

Thanks for the heads up re: merging, and for the link - I'll take a read and will make sure I merge. :)

@xtrasimplicity
Copy link
Member

xtrasimplicity commented Jun 2, 2018

With jruby, we're using the alpine image which may not include the git client (given alpine is pretty lightweight), maybe we should move to a circle CI-specific JRuby image?

I.e. circleci/jruby:9.1.16.0-jdk rather than jruby:jruby:9.1.16.0-jdk-alpine?

@ghost ghost assigned xtrasimplicity Jun 3, 2018
@xtrasimplicity
Copy link
Member

xtrasimplicity commented Jun 3, 2018

Switched the JRuby image in CircleCI config from the Alpine image to the CircleCI one, which has fixed the CI issues. Will merge once the changelog changes in CI complete! 👍

@xtrasimplicity xtrasimplicity merged commit ab5dc5a into master Jun 3, 2018
@xtrasimplicity xtrasimplicity deleted the gherkin-5.1.0-cukexp-6.0.0 branch June 3, 2018 09:17
@lock
Copy link

lock bot commented Jun 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants