Expose names of AST elements in Before hook #430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| names = [] | ||
| Before do |scenario| | ||
| names << scenario.feature_name | ||
| if scenario.respond_to?(:scenario_name) |
There was a problem hiding this comment.
@mattwynne the question is what you want to fix here, what functionality want to provide?
The code in question looks like "if I have scenario then I need its name else I have scenario outline and I need a lot of information" imho it is hard to replace such code until you have better wording for the code.
This was referenced Apr 8, 2013
|
I think that as of 7a1ec15 this is now covered. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See vcr/vcr#288 and #425.
We should make this part of the public API.