Make the scenario object available in hooks compatible with v1.3.x

[brasmusson]

#768 identified that the scenario.name of the scenario object available in hooks includes the keyword, which makes it different compared to the case in v1.3.x. Unfortunately, also after the changes triggered by #768, the keyword is still included in scenario.name (see the before_hook.feature).

In case of Scenario Outlines, achieving full compatibility with v1.3.x is rather complicated as in that case scenario.name is cell values for the example row, and scenario.scenario_outline.name is the name of the Scenario Outline. The name of the test_case is neither, it is <scenario outline name>, <examples table name> (row <nr>).

The name of the test_case is in a sense quite informative, so it raises the question of how important backward compatibility is in this specific case.

[mattwynne]

IMO the scenario.name in the hook should be the test case's name.

People need to get used to thinking of that thing as a test case anyway.

[mattwynne]

See also #430

[brasmusson]

I pushed up the change everyone agree on to the master (cucumber/common@eb950d1), that the keyword should not be part of the name exposed to the hooks.

I leave the PR open (rebased) as a place holder for the discussion if we should opt for exact compatibility with v1.3.x, and if not, whether the example row cell values should be make available to hooks (in v1.3.x they are part of the name).

[mattwynne]

I think we should expose the cell values, but through their own attributes.

[brasmusson]

Maybe with a method cell_values on ScenarioOutlineExample, that returns what Cucumber::Core::Ast::ExampleTrable::Row.values returns.

[mattwynne]

I say we close this and don't merge. Any objections?

[brasmusson]

No objection.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.