Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved features to new structure #455

Merged
merged 8 commits into from
May 15, 2013

Conversation

chrismdp
Copy link

I've moved a few new features over and taken the opportunity to rework
some of the preambles to make them into better docs.

@mattwynne
Copy link
Member

Thanks!

Would you mind rebasing this from origin master? Things have moved on a little bit since you made this PR.

@chrismdp
Copy link
Author

Rebased.

@mattwynne
Copy link
Member

Can you have a look at why the build has failed?

@chrismdp
Copy link
Author

Hmm - interesting. When a RuntimeError is thrown with an string error message, Cucumber now outputs the entire (rather unhelpful) callstack. Switching to a regular RuntimeError (no message) fixed it locally.

@chrismdp
Copy link
Author

Damn, same error. This is working for me locally when I just run the one feature, but not when I run them all. Will continue to investigate.

Chris Parsons added 5 commits May 15, 2013 11:32
Also take the opportunity to add better documentation to the feature
preamble (mostly lifted from the wiki)
I'm not convinced this feature is really necessary. It's not clearly
documenting anything, and the test itself is pretty useless.
Took the opportunity to make the preamble clearer.
@chrismdp
Copy link
Author

Ok, I've fixed by including the @spawn hook at the top of the feature file, but this is not ideal as it slows the feature down. Any idea why cucumber dumps out a massive call stack when cucumber is run inline?

Could always change the example to be less brittle, but not showing the error you normally get would be a shame from a documentation point of view.

-- also includes a newly imported feature for snippets as a bonus :)

mattwynne added a commit that referenced this pull request May 15, 2013
@mattwynne mattwynne merged commit 787282d into cucumber:master May 15, 2013
@mattwynne
Copy link
Member

I think that going through and trying to understand / remove as many @Spawn tags as possible will be a worthwhile thing to do, but in a second pass once we've migrated all the features out of the legacy directory.

@mattwynne
Copy link
Member

Not sure about the big backtrace. There's code in Cucumber that filters the backtrace, and possibly something in this new in-process Aruba is breaking that.

@chrismdp
Copy link
Author

Yeah - annoying. I'm working my way through the features - expect another PR shortly :)

@chrismdp
Copy link
Author

Goes some way to helping with #408.

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants