-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved features to new structure #455
Moved features to new structure #455
Conversation
Thanks! Would you mind rebasing this from origin master? Things have moved on a little bit since you made this PR. |
Rebased. |
Can you have a look at why the build has failed? |
Hmm - interesting. When a |
Damn, same error. This is working for me locally when I just run the one feature, but not when I run them all. Will continue to investigate. |
Also take the opportunity to add better documentation to the feature preamble (mostly lifted from the wiki)
I'm not convinced this feature is really necessary. It's not clearly documenting anything, and the test itself is pretty useless.
Took the opportunity to make the preamble clearer.
Ok, I've fixed by including the Could always change the example to be less brittle, but not showing the error you normally get would be a shame from a documentation point of view. -- also includes a newly imported feature for snippets as a bonus :) |
Moved features to new structure
I think that going through and trying to understand / remove as many @Spawn tags as possible will be a worthwhile thing to do, but in a second pass once we've migrated all the features out of the legacy directory. |
Not sure about the big backtrace. There's code in Cucumber that filters the backtrace, and possibly something in this new in-process Aruba is breaking that. |
Yeah - annoying. I'm working my way through the features - expect another PR shortly :) |
Goes some way to helping with #408. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I've moved a few new features over and taken the opportunity to rework
some of the preambles to make them into better docs.