Migrate legacy_features into features directory

[mattwynne]

This is confusing for contributors. There's no reason we can't get started now, but I want this to be on the checklist for 2.0

For context, the 'legacy' directory contains features that were written before aruba. Many of them will only require a small amount of work to port them to aruba, some will need more work, some should probably just be deleted.

[rdvdijk]

This confused me as well. I didn't even know about aruba before I read about it here.

[mattwynne]

I just realised, working on #358, that rake cucumber is no longer running rake legacy_features. Haven't worked out why yet, but this has probably been happening for some time.

[mattwynne]

@tooky @os97673 I think we need to make this ticket our top priority so we know that our refactoring work is safely covered by tests.

[aslakhellesoy]

On Monday, May 6, 2013, Matt Wynne wrote:

I just realised, working on #358cucumber/common#358,
that rake cucumber is no longer running rake legacy_features. Haven't
worked out why yet, but this has probably been happening for some time.

Did you try to git blame this? It would be nice to find out when it broke
so we can improve developer docs / build script comments and prevent it
from happening again.

P.S. if it was me please blame Oleg ;-P

Aslak

—
Reply to this email directly or view it on GitHubhttps://github.com/cucumber/common/issues/408#issuecomment-17476206
.

[mattwynne]

@aslakhellesoy it's hard to use git blame for this as what we need to analyse is historical travis output - when it stopped doing both feature runs. Or I guess we could just bisect the git history.

I suspect it might have something to do with #400 but I did some quick testing and couldn't really see why it would have caused it. I don't understand enough about Rake's API, but it seemed that the first task (rake features) was causing rake to exit (with status code 1) despite having had no errors.

[chrismdp]

PRs #459, #460, #461, #462, #463, #464 and #465 all moving features to the new structure.

[mattwynne]

Done! Big thanks to @jimvm.

[os97673]

Done! Big thanks to @jimvm.

So, should it be closed? ;)

[tooky]

\o/ great work @jimvm

[jimvm]

Glad I could help!

Somewhat related, what about the fixtures directory? I don't think the json, self_test, and steps_library are in use anymore. Maybe these can be removed?

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.