Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrates multiline_names feature to new structure #461

Merged
merged 3 commits into from
May 16, 2013

Conversation

chrismdp
Copy link

No description provided.

@mattwynne
Copy link
Member

We should update this feature. The correct terminology is that the elements break down like this:

Feature: Feature name (single line)
  This is the description, which is different to the name
  and can span over multiple lines.

  We can even have blank lines, we just mustn't mention a 
  magic word like `Background:` or `Scenario:` at the beginning
  of a line otherwise Gherkin will start to pay attention.

  That's the end of the description.

So the feature itself should be called 'multiline descriptions' and the examples (and their indentation) should be changed so the terminology is clear.

@chrismdp
Copy link
Author

I've incorporated the spirit of what's going on into the feature. I've dropped 'multiline' as that doesn't really make sense to a reader, and it's implicit in the feature.

otherwise Gherkin will start to pay attention.

Scenario: Multiline scenario
Given a file named "features/multiline_name.feature" with:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of this file is still a bit dodgy! :)

@chrismdp
Copy link
Author

Thanks for the detailed feedback - helps very much as I ease into the codebase :) I've incorporated it into the latest commit.

Feature: descriptions everywhere

We can put a useful description here of the feature, which can
span multiple line.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line -> lines

@chrismdp
Copy link
Author

More feedback changes incorporated.

Then the stderr should not contain anything
Then it should pass with:
"""
Feature: descriptions everywhere
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is out here, or it appears to be on the GH rendering of the diff. It should be left-aligned with the first " of the """

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@mattwynne
Copy link
Member

Thanks Chris!

@tooky tooky closed this May 16, 2013
@tooky
Copy link
Member

tooky commented May 16, 2013

On Thursday, 16 May 2013 at 11:11, Matt Wynne wrote:

Thanks Chris!

👍

@tooky tooky reopened this May 16, 2013
mattwynne added a commit that referenced this pull request May 16, 2013
Migrates multiline_names feature to new structure
@mattwynne mattwynne merged commit 6490d56 into cucumber:master May 16, 2013
@chrismdp chrismdp deleted the migrate-multiline-names branch May 16, 2013 12:24
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants