-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrates multiline_names feature to new structure #461
Conversation
We should update this feature. The correct terminology is that the elements break down like this:
So the feature itself should be called 'multiline descriptions' and the examples (and their indentation) should be changed so the terminology is clear. |
I've incorporated the spirit of what's going on into the feature. I've dropped 'multiline' as that doesn't really make sense to a reader, and it's implicit in the feature. |
otherwise Gherkin will start to pay attention. | ||
|
||
Scenario: Multiline scenario | ||
Given a file named "features/multiline_name.feature" with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name of this file is still a bit dodgy! :)
Thanks for the detailed feedback - helps very much as I ease into the codebase :) I've incorporated it into the latest commit. |
Feature: descriptions everywhere | ||
|
||
We can put a useful description here of the feature, which can | ||
span multiple line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line -> lines
More feedback changes incorporated. |
Then the stderr should not contain anything | ||
Then it should pass with: | ||
""" | ||
Feature: descriptions everywhere |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation is out here, or it appears to be on the GH rendering of the diff. It should be left-aligned with the first "
of the """
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Thanks Chris! |
On Thursday, 16 May 2013 at 11:11, Matt Wynne wrote:
👍 |
Migrates multiline_names feature to new structure
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.