Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the legacy Profile Feature #408 #540

Merged
merged 6 commits into from
Sep 21, 2013

Conversation

jimvm
Copy link
Contributor

@jimvm jimvm commented Sep 20, 2013

What I did:

  • Moved profile.feature from legacy_features/ to features/docs/.
  • Removed an unnecessary setup step.
  • Updated all relevant steps to Aruba steps.
  • Created a profile_steps.rb file in features/lib/step_definitions/ and added all the undefined steps.
  • Made the undefined steps work.
  • Clean up the Profile Feature file a bit.

os97673 added a commit that referenced this pull request Sep 21, 2013
@os97673 os97673 merged commit e74773a into cucumber:master Sep 21, 2013
@os97673
Copy link
Member

os97673 commented Sep 21, 2013

Thank you for the contribution

@@ -0,0 +1,15 @@
Given /^the following profiles? (?:are|is) defined:$/ do |profiles|
step 'a file named "cucumber.yml" with:', profiles
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're encouraging users to use methods rather than calling steps from stepdefs.

I think we should do what we preach - call the Aruba API method instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand. I made a pull request to fix this. See #543.

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants