Support embedding data directly in gherkin formatters #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brasmusson
changed the title
|
@brasmusson can you rebase this and then merge it into master please? |
|
@mattwynne I'll take care of it. |
The gherkin JSON formatter will encode the data it receives before inserting it into the json file. When supporting embedding images in html files, the data sent to the embed method need to be base64 encoded. Unless decoded before sent to the gherkin JSON formatter, the base64 encoding will be applied twice.
brasmusson
force-pushed
the
embed-data-directly-v1.3.x
branch
from
1c5416e to
ffc692b
Compare
brasmusson
added a commit
that referenced
this pull request
Aug 25, 2014
brasmusson
added a commit
that referenced
this pull request
Aug 25, 2014
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets out to fix part 1 of #651 ("fix the JSON report formatter").
The idea is to support the following construct in step definitions:
The GherkinFormatterAdapter will now check if the first parameter given to the embed method is indeed a file, and if so read the content of the file and send it to the gherkin formatter (for instance the JSON Formatter) as before. When the first parameter given to the embed method is not a file, then the GherkinFormatterAdapter will now assume it is the data to embed, and send that parameter through to the gherkin formatter.