Support embedding images directly in html files #696
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets out to fix part 2 of #651 ("some kind of official option on embed images [using the HTML formatter]"), or at least it does remove the need to prefix the image data with
"data:image/<format>;base64,
, manually (a prefix that is not relevant for files produces by other formatters, like the JSON formatter).The idea is to support the following construct in step definitions:
The HTML formatter will now check whether the first argument to the embed method is a file, or if it starts with the image embedding directive (
"data:image/<format>;base64,
), and if so insert the first argument as is in the src attribute of the HTML image element. Otherwise it will insert the image embedding directive first in the content of the first argument to the embed method, and insert the result as is in the src attribute of the HTML image element.