Resolve issue 961

[danascheider]

Summary

This PR resolves issue #961, where bundle install fails because of cucumber-ruby-wire. It makes changes to the Gemfile so that if the user does not have cucumber-ruby-wire locally, or doesn't have it in the expected location, it will be fetched from git instead of erroring out.

Details

Added a conditional to the Gemfile to check whether the cucumber-ruby-wire code exists locally in the expected location and, if not, gets it from git instead.

Motivation and Context

This issue was causing errors in bundle install, making it harder for developers to work on Cucumber.

How Has This Been Tested?

Gemfile change probably doesn't need tests.

Screenshots (if appropriate):

Types of changes

• [x ] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• I've added tests for my code
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[danascheider]

This commit is haunting me, it wants to be in all my PRs for some reason!!

[brasmusson]

Of course, it is not on cucumber:master but it is on the PR branch. This time (but not in the case of #982), its parent commit is the tip of cucumber:master so I pushed it to cucumber:master, it should disappear from this PR now.

[danascheider]

Thank you!

[danascheider]

Any objections to my merging this @mattwynne or @brasmusson? Speak now or forever hold your peace!

[mattwynne]

👍 but bear in mind we should make the wire plugin opt-in for 3.0 anyway so was can remove it as a dependency now I think 😀 Right @tooky?

[ghost]

@danascheider Please don't use git:// this cannot be forwarded via HTTP proxies. Better use https:// instead. Otherwise contributors behind HTTP-proxies need to rewrite the Gemfile each time they want to submit a PR and don't have local clones.

[danascheider]

Oh jeez, can't believe I didn't notice that. Thanks for pointing that out - will change.

[ghost]

Thanks a lot. :-)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.