Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change git:// to https:// #998

Merged
merged 2 commits into from
Jul 15, 2016
Merged

Change git:// to https:// #998

merged 2 commits into from
Jul 15, 2016

Conversation

danascheider
Copy link
Contributor

Summary

This PR changes git:// to https:// in the Gemfile, correcting a change made in #983.

Motivation and Context

This change will enable forwarding via HTTP proxies.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@brasmusson brasmusson merged commit 0f4619f into master Jul 15, 2016
brasmusson added a commit that referenced this pull request Jul 15, 2016
@brasmusson
Copy link
Contributor

To be consistent, I think we should use "https://" everywhere in the Gemfile, so I fixed that (0f4619f) and merged.

@brasmusson brasmusson deleted the fix-gemfile branch July 15, 2016 07:21
@danascheider
Copy link
Contributor Author

Oh thanks @brasmusson, I had only noticed it in that one place.

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants