feat: remove underscore from test files #198

dadi · Dec 1, 2017 · 307943e · 307943e
1 parent c2095c0
commit 307943e
Show file tree

Hide file tree

Showing 13 changed files with 15 additions and 19 deletions.
diff --git a/test/acceptance/app.js b/test/acceptance/app.js
@@ -1,4 +1,3 @@
-var _ = require("underscore")
 var nock = require("nock")
 var path = require("path")
 var request = require("supertest")
@@ -30,7 +29,9 @@ describe("Application", function() {
       .times(5)
       .reply(200, { accessToken: "xx" })
 
-    var scope1 = nock(apiHost).get("/").reply(200)
+    var scope1 = nock(apiHost)
+      .get("/")
+      .reply(200)
 
     var configUpdate = {
       server: {
@@ -135,7 +136,10 @@ describe("Application", function() {
 
         TestHelper.enableApiConfig().then(() => {
           TestHelper.startServer(pages).then(() => {
-            client.get("/api/status").expect(405).end(done)
+            client
+              .get("/api/status")
+              .expect(405)
+              .end(done)
           })
         })
       })
@@ -158,7 +162,11 @@ describe("Application", function() {
 
         TestHelper.enableApiConfig().then(() => {
           TestHelper.startServer(pages).then(() => {
-            client.post("/api/status").send({}).expect(401).end(done)
+            client
+              .post("/api/status")
+              .send({})
+              .expect(401)
+              .end(done)
           })
         })
       })

diff --git a/test/acceptance/public.js b/test/acceptance/public.js
@@ -1,4 +1,3 @@
-var _ = require("underscore")
 var fs = require("fs")
 var nock = require("nock")
 var path = require("path")

diff --git a/test/acceptance/routing.js b/test/acceptance/routing.js
@@ -1,4 +1,3 @@
-var _ = require("underscore")
 var nock = require("nock")
 var path = require("path")
 var request = require("supertest")

diff --git a/test/help.js b/test/help.js
@@ -1,4 +1,3 @@
-var _ = require("underscore")
 var assert = require("assert")
 var fs = require("fs")
 var nock = require("nock")
@@ -85,14 +84,14 @@ TestHelper.prototype.enableApiConfig = function() {
 TestHelper.prototype.getConfig = function() {
   return new Promise((resolve, reject) => {
     var originalConfig = JSON.parse(this.originalConfigString)
-    return resolve(_.extend({}, originalConfig))
+    return resolve(Object.assign({}, originalConfig))
   })
 }
 
 TestHelper.prototype.updateConfig = function(configBlock) {
   return new Promise((resolve, reject) => {
     var originalConfig = JSON.parse(this.originalConfigString)
-    var newConfig = _.extend(originalConfig, configBlock)
+    var newConfig = Object.assign(originalConfig, configBlock)
 
     fs.writeFileSync(config.configPath(), JSON.stringify(newConfig, null, 2))
     config.loadFile(path.resolve(config.configPath()))
@@ -197,7 +196,7 @@ TestHelper.prototype.newPage = function(
 
 TestHelper.prototype.startServer = function(pages) {
   return new Promise((resolve, reject) => {
-    if (pages !== null && !_.isArray(pages)) {
+    if (pages !== null && !Array.isArray(pages)) {
       pages = [pages]
     }
 

diff --git a/test/unit/config.js b/test/unit/config.js
@@ -1,4 +1,3 @@
-var _ = require("underscore")
 var fs = require("fs")
 var path = require("path")
 var should = require("should")

diff --git a/test/unit/controller.js b/test/unit/controller.js
@@ -1,4 +1,3 @@
-var _ = require("underscore")
 var nock = require("nock")
 var request = require("supertest")
 var should = require("should")

diff --git a/test/unit/helpTest.js b/test/unit/helpTest.js
@@ -1,4 +1,3 @@
-var _ = require("underscore")
 var fs = require("fs")
 var nock = require("nock")
 var request = require("supertest")

diff --git a/test/unit/monitor.js b/test/unit/monitor.js
@@ -1,4 +1,3 @@
-var _ = require("underscore")
 var fs = require("fs")
 var path = require("path")
 var should = require("should")

diff --git a/test/unit/preloader.js b/test/unit/preloader.js
@@ -1,4 +1,3 @@
-var _ = require("underscore")
 var fs = require("fs")
 var nock = require("nock")
 var path = require("path")

diff --git a/test/unit/router.js b/test/unit/router.js
@@ -1,4 +1,3 @@
-var _ = require("underscore")
 var fs = require("fs")
 var nock = require("nock")
 var request = require("supertest")

diff --git a/test/unit/server.js b/test/unit/server.js
@@ -1,4 +1,3 @@
-var _ = require("underscore")
 var path = require("path")
 var should = require("should")
 var sinon = require("sinon")

diff --git a/test/unit/view.js b/test/unit/view.js
@@ -1,4 +1,3 @@
-var _ = require("underscore")
 var dust = require("dustjs-linkedin")
 var dustHelpers = require("dustjs-helpers")
 var fs = require("fs")

diff --git a/workspace/utils/helpers/paginate.js b/workspace/utils/helpers/paginate.js
@@ -1,5 +1,4 @@
 var dust = require("dustjs-linkedin")
-var _ = require("underscore")
 
 /*
 * Paginate pages