Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Underscore dependency #198

Closed
17 tasks done
abovedave opened this issue Aug 10, 2017 · 3 comments
Closed
17 tasks done

Remove Underscore dependency #198

abovedave opened this issue Aug 10, 2017 · 3 comments
Labels
type: maintenance

Comments

@abovedave
Copy link
Contributor

abovedave commented Aug 10, 2017 •
edited by eduardoboucas
Loading

  • lib/api/index.js
  • lib/cache/index.js
  • lib/controller/router.js
  • lib/providers/markdown.js
  • lib/providers/static.js
  • lib/providers/dadiapi.js
  • lib/providers/remote.js
  • lib/providers/rss.js
  • lib/providers/twitter.js
  • lib/providers/wordpress.js
  • lib/templates/store.js
  • lib/datasource/preload.js
  • lib/controller/index.js
  • lib/controller/forceDomain.js
  • lib/view/public.js
  • lib/help.js
  • lib/index.js
@abovedave abovedave mentioned this issue Nov 29, 2017
Merged
5 tasks
@adamkdean
Copy link
Contributor

Is the plan to replace this with something else, like individual lodash methods?

@mingard
Copy link
Contributor

mingard commented Nov 29, 2017

We can entirely do without it IMO.

abovedave pushed a commit that referenced this issue Dec 1, 2017
feat: remove underscore.string #198
a0d6d46
@abovedave abovedave mentioned this issue Dec 1, 2017
Merged
abovedave pushed a commit that referenced this issue Dec 1, 2017
feat: remove underscore from test files #198
307943e
@abovedave
Copy link
Contributor Author

I'll sort these guys (they're taken from our Dust.js helpers repo)

web/workspace/utils/helpers/paginate.js

Line 2 in 2f473a6

var _ = require("underscore")

web/workspace/utils/helpers/paginate.js

Line 151 in 2f473a6

_.each(makeSteps(1, current, "increase"), printStepOrGap)

web/workspace/utils/helpers/paginate.js

Line 159 in 2f473a6

_.each(makeSteps(current, totalPages, "decrease"), printStepOrGap)

abovedave pushed a commit that referenced this issue Dec 6, 2017
Remove underscore string (#305)
1b7d9cf 
* feat: remove underscore.string #198

* feat: simplify token path generation

* fix: readability

* fix: cache flush

* fix: bearer token
abovedave pushed a commit that referenced this issue Dec 6, 2017
@jimlambie
Datasource parameter extension (#297)
4836813 
* feat: obtain parameter from config, session, request

* chore: package lock

* refactor: remove underscorejs from ds module

* feat: inject parameters into chained ds endpoints

* refactor: remove underscore from view/public.js

* refactor: remove underscore usage

* refactor: favour const over let

* style: fix JSON indents

* refactor: remove underscore usage

* refactor: remove underscorejs usage

* refactor: remove underscorejs usage

* refactor: remove underscore usage

* refactor: remove underscorejs usage

* refactor: remove underscorejs usage

* fix: return first component in array

* fix: disable coverage check

* refactor: remove underscore usage

* style: standardjs

* chore: update package, remove underscore dependency 🎉

* feat: allow modification of ds endpoint from a special event

* feat: remove underscore from test files #198

* Remove underscore string (#305)

* feat: remove underscore.string #198

* feat: simplify token path generation

* fix: readability

* fix: cache flush

* fix: bearer token
abovedave pushed a commit that referenced this issue Dec 7, 2017
Simplify start page (#310)
12e1a80 
* feat: obtain parameter from config, session, request

* chore: package lock

* refactor: remove underscorejs from ds module

* feat: inject parameters into chained ds endpoints

* refactor: remove underscore from view/public.js

* refactor: remove underscore usage

* refactor: favour const over let

* style: fix JSON indents

* refactor: remove underscore usage

* refactor: remove underscorejs usage

* refactor: remove underscorejs usage

* refactor: remove underscore usage

* refactor: remove underscorejs usage

* refactor: remove underscorejs usage

* fix: return first component in array

* fix: disable coverage check

* refactor: remove underscore usage

* style: standardjs

* chore: update package, remove underscore dependency 🎉

* feat: allow modification of ds endpoint from a special event

* feat: remove underscore from test files #198

* feat: new default page

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: tests

* fix: coverage badge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jimlambie @abovedave @mingard @adamkdean