Remove underscore string #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abovedave
changed the base branch from
develop
to
feature/datasource-parameter-extension
|
Backstory: We are including all of |
|
Looks good to me! |
abovedave
pushed a commit
that referenced
this pull request
Dec 6, 2017
* feat: obtain parameter from config, session, request * chore: package lock * refactor: remove underscorejs from ds module * feat: inject parameters into chained ds endpoints * refactor: remove underscore from view/public.js * refactor: remove underscore usage * refactor: favour const over let * style: fix JSON indents * refactor: remove underscore usage * refactor: remove underscorejs usage * refactor: remove underscorejs usage * refactor: remove underscore usage * refactor: remove underscorejs usage * refactor: remove underscorejs usage * fix: return first component in array * fix: disable coverage check * refactor: remove underscore usage * style: standardjs * chore: update package, remove underscore dependency 🎉 * feat: allow modification of ds endpoint from a special event * feat: remove underscore from test files #198 * Remove underscore string (#305) * feat: remove underscore.string #198 * feat: simplify token path generation * fix: readability * fix: cache flush * fix: bearer token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at this function - is it needed? I think we're covered because the
hosthas to be either an IP address (valid as a filename), OR a hostname, which are also valid directly as filenames?Maybe this might be more robust to account for random chars in
clientId?