Simplify start page #310
Merged
Simplify start page #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tasource-parameter-extension
…adi/web into feature/datasource-parameter-extension
…ub.com/dadi/web into feature/datasource-parameter-extension
…6-start-page # Conflicts: # dadi/lib/help.js # package-lock.json # package.json # workspace/utils/helpers/paginate.js
added 3 commits
December 7, 2017 11:53
added 2 commits
December 7, 2017 12:25
jimlambie
reviewed
Dec 7, 2017
README.md
Outdated
| @@ -1,7 +1,7 @@ | |||
| <img src="https://dadi.tech/assets/products/dadi-web-full.png" alt="DADI Web" height="65"/> | |||
|
|
|||
| [](https://www.npmjs.com/package/@dadi/web) | |||
| [](https://github.com/dadi/web) | |||
| [](https://github.com/dadi/web) | |||
There was a problem hiding this comment.
this looks a bit odd, Eduardo had an issue with this earlier too. Modify scripts/coverage.js to not do the badgeUrl.replace step...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes Dust.js and it's dependencies from the Web core. Instead there is a simple start page powered by the ES6 template engine (rather than the previous blog configuration).
Overtime, I suggest we only recommend installing using the DADI CLI - perhaps so when you start Web without a config and/or workspace file you get a warning and a prompt to use CLI or download a workspace manually.
Thoughts?