Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECMA402 datetime format to package:intl4x #680

Merged
merged 21 commits into from
Jul 24, 2023
Merged

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Jul 18, 2023

Add the browsers DateTime formatting functionality.

Note: Also has the changes from #683 to run the checks.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions
Copy link

github-actions bot commented Jul 18, 2023

PR Health

Package publish validation ✔️

Details
Package Version Status
package:intl4x 0.5.0 ready to publish
package:intl 0.19.0-dev pre-release version (no publish necessary)
package:intl_translation 0.19.0-dev pre-release version (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

License Headers ✔️

Details
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/intl_translation/example/lib/generated/messages_en.dart
pkgs/intl_translation/example/lib/generated/messages_all_locales.dart
pkgs/intl_translation/example/lib/generated/messages_all.dart
pkgs/intl_translation/example/lib/generated/messages_es.dart
pkgs/intl_translation/example/lib/generated/messages_iw.dart
pkgs/intl_translation/example/lib/generated/messages_de.dart
pkgs/intl_translation/example/lib/generated/messages_de_CH.dart
pkgs/intl_translation/test/generate_localized/code_map_messages_all_locales.dart
pkgs/intl_translation/test/generate_localized/code_map_messages_fr.dart
pkgs/intl_translation/test/generate_localized/code_map_messages_all.dart
pkgs/intl_translation/test/two_components/component_messages_all.dart
pkgs/intl_translation/test/two_components/component_messages_fr_xyz123.dart
pkgs/intl_translation/test/two_components/app_messages_all_locales.dart
pkgs/intl_translation/test/two_components/app_messages_all.dart
pkgs/intl_translation/test/two_components/component_messages_all_locales.dart
pkgs/intl_translation/test/two_components/app_messages_fr.dart

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️

Details
File Coverage
pkgs/intl4x/lib/collation.dart 💔 Not covered
pkgs/intl4x/lib/datetime_format.dart 💔 Not covered
pkgs/intl4x/lib/display_names.dart 💔 Not covered
pkgs/intl4x/lib/intl4x.dart 💚 100 %
pkgs/intl4x/lib/list_format.dart 💔 Not covered
pkgs/intl4x/lib/number_format.dart 💔 Not covered
pkgs/intl4x/lib/src/datetime_format/datetime_format.dart 💚 100 %
pkgs/intl4x/lib/src/datetime_format/datetime_format_4x.dart 💚 17 %
pkgs/intl4x/lib/src/datetime_format/datetime_format_ecma.dart 💚 100 %
pkgs/intl4x/lib/src/datetime_format/datetime_format_impl.dart 💚 100 %
pkgs/intl4x/lib/src/datetime_format/datetime_format_options.dart 💚 20 %
pkgs/intl4x/lib/src/datetime_format/datetime_format_stub.dart 💔 Not covered
pkgs/intl4x/lib/src/display_names/display_names_4x.dart 💚 5 %
pkgs/intl4x/lib/src/display_names/display_names_options.dart 💔 0 % ⬇️ NaN %
pkgs/intl4x/lib/src/list_format/list_format.dart 💚 100 %
pkgs/intl4x/lib/src/list_format/list_format_options.dart 💔 0 % ⬇️ NaN %
pkgs/intl4x/lib/src/number_format/number_format_options.dart 💚 77 %
pkgs/intl4x/lib/src/options.dart 💔 14 % ⬇️ 57 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check

@mosuem mosuem self-assigned this Jul 18, 2023
@mosuem mosuem requested a review from devoncarew July 18, 2023 14:13
@github-actions github-actions bot added the infra label Jul 19, 2023
@mosuem mosuem changed the base branch from main to fixWorkflows July 19, 2023 11:10
@mosuem mosuem changed the base branch from fixWorkflows to main July 19, 2023 11:16
@github-actions github-actions bot removed the infra label Jul 20, 2023
@dart-lang dart-lang deleted a comment from github-actions bot Jul 20, 2023
@github-actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:intl4x 0.5.0 ready to publish intl4x-v0.5.0
package:intl 0.19.0-dev pre-release version (no publish necessary)
package:intl_translation 0.19.0-dev pre-release version (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@mosuem mosuem merged commit b963401 into main Jul 24, 2023
@mosuem mosuem deleted the addIntl4xDatetimeFormat branch July 24, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants