-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ECMA402 datetime format to package:intl4x #680
Conversation
PR HealthPackage publish validation ✔️Details
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. License Headers ✔️Details
All source files should start with a license header. Unrelated files missing license headers
Changelog Entry ✔️Details
Changes to files need to be accounted for in their respective changelogs. Coverage
|
File | Coverage |
---|---|
pkgs/intl4x/lib/collation.dart | 💔 Not covered |
pkgs/intl4x/lib/datetime_format.dart | 💔 Not covered |
pkgs/intl4x/lib/display_names.dart | 💔 Not covered |
pkgs/intl4x/lib/intl4x.dart | 💚 100 % |
pkgs/intl4x/lib/list_format.dart | 💔 Not covered |
pkgs/intl4x/lib/number_format.dart | 💔 Not covered |
pkgs/intl4x/lib/src/datetime_format/datetime_format.dart | 💚 100 % |
pkgs/intl4x/lib/src/datetime_format/datetime_format_4x.dart | 💚 17 % |
pkgs/intl4x/lib/src/datetime_format/datetime_format_ecma.dart | 💚 100 % |
pkgs/intl4x/lib/src/datetime_format/datetime_format_impl.dart | 💚 100 % |
pkgs/intl4x/lib/src/datetime_format/datetime_format_options.dart | 💚 20 % |
pkgs/intl4x/lib/src/datetime_format/datetime_format_stub.dart | 💔 Not covered |
pkgs/intl4x/lib/src/display_names/display_names_4x.dart | 💚 5 % |
pkgs/intl4x/lib/src/display_names/display_names_options.dart | 💔 0 % ⬇️ NaN % |
pkgs/intl4x/lib/src/list_format/list_format.dart | 💚 100 % |
pkgs/intl4x/lib/src/list_format/list_format_options.dart | 💔 0 % ⬇️ NaN % |
pkgs/intl4x/lib/src/number_format/number_format_options.dart | 💚 77 % |
pkgs/intl4x/lib/src/options.dart | 💔 14 % ⬇️ 57 % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
Add the browsers
DateTime
formatting functionality.Note: Also has the changes from #683 to run the checks.
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.