-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow changes #683
Workflow changes #683
Conversation
PR HealthPackage publish validation ✔️Details
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. License Headers ✔️Details
All source files should start with a license header. Unrelated files missing license headers
Changelog Entry ✔️Details
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️Details
This check for test coverage is informational (issues shown here will not fail the PR). |
@@ -5,6 +5,6 @@ on: | |||
types: [opened, synchronize, reopened, labeled, unlabeled] | |||
jobs: | |||
health: | |||
uses: dart-lang/ecosystem/.github/workflows/health.yaml@main | |||
uses: dart-lang/ecosystem/.github/workflows/health.yaml@a52ac638c03b8f2356c2ab9168ff27f83b379177 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have concerns w/ using main
here, as we control the repo in question (just a question of whether you want to always get the latest of have a specific version).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just about pinning to a version which is not currently part of the posting-comments-on-forks debugging
health
workflow version while debuggingpackage:firehose
.package:intl4x
.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.