Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow changes #683

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Workflow changes #683

merged 1 commit into from
Jul 20, 2023

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Jul 19, 2023

  • Switch to a stable health workflow version while debugging package:firehose.
  • Allow numbers in package names, to enable autopublishing of package:intl4x.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@mosuem mosuem requested a review from devoncarew July 19, 2023 11:09
@github-actions github-actions bot added the infra label Jul 19, 2023
@github-actions
Copy link

PR Health

Package publish validation ✔️

Details
Package Version Status
package:intl 0.19.0-dev pre-release version (no publish necessary)
package:intl4x 0.3.1-wip pre-release version (no publish necessary)
package:intl_translation 0.19.0-dev pre-release version (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

License Headers ✔️

Details
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/intl_translation/example/lib/generated/messages_en.dart
pkgs/intl_translation/example/lib/generated/messages_all_locales.dart
pkgs/intl_translation/example/lib/generated/messages_all.dart
pkgs/intl_translation/example/lib/generated/messages_es.dart
pkgs/intl_translation/example/lib/generated/messages_iw.dart
pkgs/intl_translation/example/lib/generated/messages_de.dart
pkgs/intl_translation/example/lib/generated/messages_de_CH.dart
pkgs/intl_translation/test/generate_localized/code_map_messages_all_locales.dart
pkgs/intl_translation/test/generate_localized/code_map_messages_fr.dart
pkgs/intl_translation/test/generate_localized/code_map_messages_all.dart
pkgs/intl_translation/test/two_components/component_messages_all.dart
pkgs/intl_translation/test/two_components/component_messages_fr_xyz123.dart
pkgs/intl_translation/test/two_components/app_messages_all_locales.dart
pkgs/intl_translation/test/two_components/app_messages_all.dart
pkgs/intl_translation/test/two_components/component_messages_all_locales.dart
pkgs/intl_translation/test/two_components/app_messages_fr.dart

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️

Details
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

@@ -5,6 +5,6 @@ on:
types: [opened, synchronize, reopened, labeled, unlabeled]
jobs:
health:
uses: dart-lang/ecosystem/.github/workflows/health.yaml@main
uses: dart-lang/ecosystem/.github/workflows/health.yaml@a52ac638c03b8f2356c2ab9168ff27f83b379177
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have concerns w/ using main here, as we control the repo in question (just a question of whether you want to always get the latest of have a specific version).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just about pinning to a version which is not currently part of the posting-comments-on-forks debugging

@mosuem mosuem merged commit ab7dd41 into main Jul 20, 2023
@mosuem mosuem deleted the fixWorkflows branch July 20, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants