Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include static member information for classes #1454

Merged
merged 6 commits into from
Dec 2, 2021

Conversation

elliette
Copy link
Contributor

Work towards #1430

Include static member information for classes now that DDC is exposing static member names (see dart-lang/sdk@cc9353a).

@google-cla google-cla bot added the cla: yes label Nov 24, 2021
@elliette elliette requested review from nshahan and annagrin November 24, 2021 22:29
@elliette
Copy link
Contributor Author

Hi @nshahan - is there a way to tell if your change is on stable or not? I'm wondering if that's why we're seeing the failing tests. If that's the case, it might make sense to pin the Dart SDK to the version your change is on.

Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Elliott!

Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the description of the change to dwds/CHANGELOG.md?

@nshahan
Copy link
Contributor

nshahan commented Nov 30, 2021

is there a way to tell if your change is on stable or not?

It has not been published in a stable release yet. It looks like it is present in the current beta starting at version 2.15.0-268.18.beta so it should be part of the next stable release.

@annagrin
Copy link
Contributor

annagrin commented Dec 1, 2021

is there a way to tell if your change is on stable or not?

It has not been published in a stable release yet. It looks like it is present in the current beta starting at version 2.15.0-268.18.beta so it should be part of the next stable release.

@elliette you can just disable the tests for anything below the version @nshahan mentioned, here is an example:

skip: semver.Version.parse(Platform.version.split(' ').first) >

@annagrin
Copy link
Contributor

annagrin commented Dec 2, 2021

Merging so we can include the change in the next dwds version.

@elliette elliette merged commit 5564eaa into dart-lang:master Dec 2, 2021
@elliette elliette deleted the issue-1430 branch December 24, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants