Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the dep on package:uuid #2415

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

devoncarew
Copy link
Member

  • remove the dep on package:uuid

This will make the repo a little easier to bring into the sdk repo.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew
Copy link
Member Author

Happy to add a changelog entry here, though I don't believe this package is published.

Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zero need for a changelog entry in my mind!

@kevmoo
Copy link
Member

kevmoo commented Apr 22, 2024

We should figure out if a UUID is really needed or if we just need a sufficiently random string. Because the code there is WAY more complex than it needs to be. We could just do base64Url with a bunch of bytes and call it a day.

Ditto for the code I swapped out in the SDK

@devoncarew
Copy link
Member Author

Landing as is to facilitate the sdk roll, but if there's any simplification we can do here (wrt less copied code), sgtm.

Copy link
Contributor

@elliette elliette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@devoncarew
Copy link
Member Author

It looks like a few bots are still running (2+ hours?) and have failures. I'm not sure if they're related to this change, but I'll hold off landing for now.

@elliette
Copy link
Contributor

It looks like a few bots are still running (2+ hours?) and have failures. I'm not sure if they're related to this change, but I'll hold off landing for now.

Not related to this change! Feel free to merge. I'm trying to fix the timeouts separately in this PR: #2416 (the --no-sound-null-safety option was removed, so the weak null safety tests were timing out on compilation). I need to figure out why the test timeout wasn't being respected.

@devoncarew devoncarew merged commit d4f9f67 into dart-lang:master Apr 22, 2024
38 of 45 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Apr 22, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/d23112a..aa139fd):
  aa139fd  2024-04-18  William Hesse  Add support for running perftools to use hardware performance counters when benchmarking. (dart-archive/benchmark_harness#98)

dartdoc (https://github.com/dart-lang/dartdoc/compare/592694e..1ae5b4c):
  1ae5b4c0  2024-04-22  dependabot[bot]  Bump actions/upload-artifact from 4.3.1 to 4.3.3 (dart-lang/dartdoc#3755)
  5934d2d6  2024-04-22  dependabot[bot]  Bump actions/checkout from 4.1.2 to 4.1.3 (dart-lang/dartdoc#3754)
  a9500f0d  2024-04-22  Sam Rawlins  Replace hasPrivateName/hasPublicName with one extension getter (dart-lang/dartdoc#3752)

tools (https://github.com/dart-lang/tools/compare/d86ea23..3e21ae9):
  3e21ae9  2024-04-22  Elias Yishak  `Event` Constructor added for devtools event (dart-lang/tools#258)

webdev (https://github.com/dart-lang/webdev/compare/3a10b76..d4f9f67):
  d4f9f672  2024-04-22  Devon Carew  remove the dep on package:uuid (dart-lang/webdev#2415)
  78555cdd  2024-04-18  Kevin Moore  FE server common: move from pkg:usage to pkg:uuid (dart-lang/webdev#2412)
  16dce1f2  2024-04-18  Elliott Brooks  Pin DCM to latest version (dart-lang/webdev#2410)
  b0494fb5  2024-04-18  Elliott Brooks  Catch errors when calculating frames in the stack trace (dart-lang/webdev#2408)

Change-Id: I1d206665e33e5936f4a5bf93e029a7290803895d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/364021
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants