Fix test timeouts related to weak null safety #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
elliette
changed the title
nshahan
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
LGTM. It seems to me that we probably could have probably deleted these tests a while ago since the change that caused the breakage looks unrelated to any web configurations we support today.
https://dart-review.googlesource.com/c/sdk/+/363340
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 25, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/1ae5b4c..d9e31ff): d9e31ff9 2024-04-22 Sam Rawlins Extract Canonicalization from the ModelElement hierarchy (dart-lang/dartdoc#3753) webdev (https://github.com/dart-lang/webdev/compare/d4f9f67..50bf268): 50bf2687 2024-04-24 Elliott Brooks Add `dwdsLaunch` and `dwdsAttach` events (dart-lang/webdev#2418) 804eb5c5 2024-04-24 Elliott Brooks Reset DWDS and WebDev after release (dart-lang/webdev#2419) 988b03bf 2024-04-23 Elliott Brooks Prepare webdev for release to version 3.5.0 (dart-lang/webdev#2417) 68513c8f 2024-04-23 Elliott Brooks Prepare DWDS for release to version 24.0.0 (dart-lang/webdev#2413) 0b188169 2024-04-22 Elliott Brooks Fix test timeouts related to weak null safety (dart-lang/webdev#2416) Change-Id: Ie366c07cf46d7efb15d67322eac045e6a6bd7fe3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/364522 Auto-Submit: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--no-sound-null-safetyoption was removed from the frontend server (see https://dart-review.googlesource.com/c/sdk/+/363340), and so now our frontend server tests for weak null safety are timing out during the compilation step (see https://github.com/dart-lang/webdev/actions/runs/8744376463/job/23997177184)This PR removes the weak null safety tests.