-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: parse decimal in expr. #10275
Merged
Merged
feat: parse decimal in expr. #10275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dec2f84
to
9511c21
Compare
youngsofun
commented
Mar 1, 2023
andylokandy
approved these changes
Mar 1, 2023
985677a
to
7e08b1d
Compare
float64 to float32 is here https://github.com/datafuselabs/databend/blob/main/src/query/functions/src/scalars/arithmetic.rs#L301 it comes last in the number_to_number functions (not include decimal) |
bde9c06
to
8acd335
Compare
This was referenced Mar 3, 2023
f74e89e
to
02eb4d7
Compare
youngsofun
commented
Mar 3, 2023
src/query/functions/tests/it/scalars/testdata/function_list_ordered.txt
Outdated
Show resolved
Hide resolved
youngsofun
commented
Mar 3, 2023
b846637
to
9851d60
Compare
sundy-li
approved these changes
Mar 5, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
trying to split this pr, a drawback is that effect of some changes need this pr to test.
Summary
1 + -1
result inplus(1, -1)
instead ofplus(1, minus(1))
notice:
not in this pr
Closes #10220
#10262