Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database_alias on mssql #4449

Closed
datatimnih opened this issue Mar 18, 2022 · 3 comments
Closed

database_alias on mssql #4449

datatimnih opened this issue Mar 18, 2022 · 3 comments
Labels
bug Bug report

Comments

@datatimnih
Copy link

datatimnih commented Mar 18, 2022

Describe the bug
i'm trying to ingest my mssql to datahub with this config

source:
  type: mssql
  config:
    uname,pas,port
    database: db_name
    database_alias: db_alias

but doesn't use the database_alias like db_alias.dbo.table its still using the database name db_name.dbo.table

To Reproduce
Steps to reproduce the behavior:

  1. creating the mssql config file with databse_alias
  2. idatahub -c ingest config_file.yml
  3. see on the datahub its stil using the original database name

Expected behavior
expected result: db_alias.dbo.table (using database_alias from config file)
actual result: db_name.dbo.table (ignoring the database_alias)

Additional context
after following some instruction from slack forum to add code similar tothis after this line.
its still using db_name and still ignoring the db_alias in the config file.

@datatimnih datatimnih added the bug Bug report label Mar 18, 2022
@datatimnih datatimnih changed the title databse_alias on mssql database_alias on mssql Mar 18, 2022
@maggiehays
Copy link
Collaborator

Hi @kevinhu! Can you take a look at this one?

@kevinhu
Copy link
Contributor

kevinhu commented Mar 29, 2022

Sure!

@kevinhu
Copy link
Contributor

kevinhu commented Mar 29, 2022

@datatimnih should be fixed! See #4523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report
Projects
None yet
Development

No branches or pull requests

4 participants