Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/superset): map awsathena platform name to athena #10005

Merged
merged 4 commits into from
Mar 11, 2024
Merged

feat(ingest/superset): map awsathena platform name to athena #10005

merged 4 commits into from
Mar 11, 2024

Conversation

LePuppy
Copy link
Contributor

@LePuppy LePuppy commented Mar 7, 2024 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Mar 7, 2024
hsheth2
hsheth2 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsheth2
Copy link
Collaborator

hsheth2 commented Mar 7, 2024

@LePuppy looks like the linter has an issue - could you run black on that file?

@LePuppy
Copy link
Contributor Author

LePuppy commented Mar 8, 2024

You're right @hsheth2 . Just ran black on that file

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Mar 8, 2024
@treff7es treff7es merged commit ae3443b into datahub-project:master Mar 11, 2024
53 checks passed
@LePuppy LePuppy deleted the feat/superset-ingestion-map-awsathena-to-athena branch March 11, 2024 15:29
esselius added a commit to esselius/datahub that referenced this pull request Aug 19, 2024
@esselius
feat(ingest/superset): clickhousedb -> clickhouse mapping in superset…
f5ec0ca 
… ingestion

Similar to datahub-project#10005
@esselius esselius mentioned this pull request Aug 19, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinzool rinzool rinzool approved these changes

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LePuppy @hsheth2 @rinzool @treff7es