Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest/superset): map awsathena platform name to athena #10005

Merged
merged 4 commits into from
Mar 11, 2024
Merged

feat(ingest/superset): map awsathena platform name to athena #10005

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b7c3add
feat(ingest/superset): map awsathena platform name to athena
LePuppy Mar 7, 2024
8cf65a0
feat(ingest/superset): replace awsathena with athena directly in the …
LePuppy Mar 7, 2024
4da34dd
ref(ingest/superset): change platform name awsathena to athena
LePuppy Mar 7, 2024
ecfa7e7
style: run black
LePuppy Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions metadata-ingestion/src/datahub/ingestion/source/superset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,8 +226,14 @@ def get_platform_from_database_id(self, database_id):
).json()
sqlalchemy_uri = database_response.get("result", {}).get("sqlalchemy_uri")
if sqlalchemy_uri is None:
return database_response.get("result", {}).get("backend", "external")
return get_platform_from_sqlalchemy_uri(sqlalchemy_uri)
platform_name = database_response.get("result", {}).get(
"backend", "external"
)
else:
platform_name = get_platform_from_sqlalchemy_uri(sqlalchemy_uri)
if platform_name == "awsathena":
return "athena"
return platform_name

@lru_cache(maxsize=None)
def get_datasource_urn_from_id(self, datasource_id):
Expand Down
Loading