feat(ingest): add classification for sql sources #10013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
mayurinehate
force-pushed
the
master+ing-319-classification_for_sql_sources
branch
from
309e4ab to
764ea8a
Compare
hsheth2
reviewed
Mar 9, 2024
metadata-ingestion/src/datahub/ingestion/source/sql/data_reader.py
Outdated
Show resolved
Hide resolved
| else: | ||
| query = sa.select([sa.text("*")]).select_from(table).limit(sample_size) | ||
| query_results = self.engine.execute(query) | ||
| # Not ideal - creates a parallel structure. Can we use pandas here ? |
There was a problem hiding this comment.
yeah refactoring the query generation a bit would be nice
metadata-ingestion/src/datahub/ingestion/source/sql/data_reader.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/sql/sql_common.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/sql/data_reader.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/sql/sql_common.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Harshal Sheth <[email protected]>
…r.py Co-authored-by: Harshal Sheth <[email protected]>
hsheth2
approved these changes
Mar 12, 2024
metadata-ingestion/src/datahub/ingestion/source/sql/data_reader.py
Outdated
Show resolved
Hide resolved
|
|
||
| # Not ideal - creates a parallel structure in column_values. Can we use pandas here ? | ||
| for row in query_results.fetchall(): | ||
| if isinstance(row, LegacyRow): |
There was a problem hiding this comment.
this LegacyRow thing seems fishy - is row always going to be a LegacyRow? won't it be a Row object in some cases?
we're on sqlalchemy 1.4, so LegacyRow should be deprecated https://docs.sqlalchemy.org/en/20/changelog/migration_14.html#rowproxy-is-no-longer-a-proxy-is-now-called-row-and-behaves-like-an-enhanced-named-tuple
There was a problem hiding this comment.
Agree. Given that LegacyRow import and functionality in sql_common.py is working fine, the current code flow should also work well for now. I've added fix for this in followup PR.
…sification_for_sql_sources' into master+ing-319-classification_for_sql_sources
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist