feat(ingest): add classification to bigquery, redshift #10031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
mayurinehate
changed the title
Contains refractoring changes for snowflake classification
mayurinehate
force-pushed
the
master+ing-547-classification-bigquery-redshift
branch
from
6795dda to
a030388
Compare
hsheth2
approved these changes
Mar 14, 2024
| data_reader_kwargs=dict( | ||
| sample_size_percent=( | ||
| self.config.classification.sample_size | ||
| * 1.2 |
There was a problem hiding this comment.
can we extract out this 1.2 constant in a follow up PR?
| @@ -447,6 +447,11 @@ class TeradataConfig(BaseTeradataConfig, BaseTimeWindowConfig): | |||
| @capability(SourceCapability.LINEAGE_COARSE, "Optionally enabled via configuration") | |||
| @capability(SourceCapability.LINEAGE_FINE, "Optionally enabled via configuration") | |||
| @capability(SourceCapability.USAGE_STATS, "Optionally enabled via configuration") | |||
| @capability( | |||
There was a problem hiding this comment.
the capability annotations support inheritance, so I don't think these are actually necessary
There was a problem hiding this comment.
wondered why we had no annotation on SQLAlchemySource source. Some like PLATFORM_INSTANCE, DOMAINS, SCHEMA_METADATA, CONTAINERS, DELETION_DETECTION can probably move in there.
mayurinehate
added a commit
to mayurinehate/datahub
that referenced
this pull request
Mar 26, 2024
- also addresses followups from datahub-project#10031 (review)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #10013
Checklist