-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bootstrap): bootstrap template mcps #11518
feat(bootstrap): bootstrap template mcps #11518
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
4b406ad
to
ba8e998
Compare
ba8e998
to
53443c9
Compare
Typically GMS runs a number of bootstrap steps, these were essentially generating MCP-like requests to add entities/aspects needed for running DataHub.
This PR introduces a new type of bootstrap MCP which uses a template so that install time options can be configured by environment variable or helm.
The bootstrap process for these MCPs was moved from GMS to the
system-update
job. This avoids unneeded latency during GMS startup and only executes the steps once during installation rather than every time GMS starts.The bootstrap steps which are simply applying MCPs were migrated
A new bootstrap MCP was added which will create a new Ingestion Source designed for garbage collection called
datahub-gc
. Scheduled to run automatically after the upgrade.DATAHUB_GC_BOOTSTRAP_VALUES
, with the override values encoded as a json objectDetailed documentation here.
Checklist