fix(ui): show DataHub logo for DataHub sources in ingestion souces list #11658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product
shirshanka
force-pushed
the
fix-ui-datahub-datahub-gc-logos
branch
from
eb260e6 to
848b52f
Compare
shirshanka
added
the
merge-pending-ci
aviv-julienjehannet
pushed a commit
to aviv-julienjehannet/datahub
that referenced
this pull request
Oct 21, 2024
…st (datahub-project#11658) Co-authored-by: Shirshanka Das <[email protected]>
epatotski
pushed a commit
to acryldata/datahub
that referenced
this pull request
Oct 22, 2024
…st (datahub-project#11658) Co-authored-by: Shirshanka Das <[email protected]>
k-bartlett
pushed a commit
to k-bartlett/datahub
that referenced
this pull request
Oct 23, 2024
…st (datahub-project#11658) Co-authored-by: Shirshanka Das <[email protected]>
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Dec 17, 2024
…st (datahub-project#11658) Co-authored-by: Shirshanka Das <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw in this PR (#11518) that for the datahub-gc source no platform logo is shown...we could show a DataHub Logo for all DataHub sources...;-)
SOURCE_TO_PLATFORM_URN and PLATFORM_URN_TO_LOGO are used by useGetSourceLogoUrl to return the logo URL:
datahub/datahub-web-react/src/app/ingest/source/builder/useGetSourceLogoUrl.ts
Line 9 in 6b09346
The entry for vertica in SOURCE_TO_PLATFORM_URN is redundant and not needed, because the platform urn is already correct for vertica and has not be "translated"...
Checklist