Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search) BREAKING Support ElasticSearch 7, drop ES5 #2263

Merged
merged 6 commits into from
Mar 19, 2021
Merged

Conversation

jplaisted
Copy link
Contributor

@jplaisted jplaisted commented Mar 19, 2021

Merges in changes from our ES7 branch, and drops support for ES5.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

John Plaisted and others added 4 commits March 18, 2021 18:02
* upgrade to ES7

* add doc summarizing the changes

* Call out the optional parameters in search query

Some parameters in search query are optional and automatically populated. With the ES upgrade these parameters could be removed/added.

* revert unrelated changes

* update required max_ngram_diff field for ES7 (caught by integration tests)

Co-authored-by: Jyoti Wadhwani <[email protected]>
@jplaisted jplaisted requested a review from shirshanka March 19, 2021 01:26
Copy link
Contributor

@dexter-mh-lee dexter-mh-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka
Copy link
Contributor

@jplaisted : need to add a file to the sidebar
Error: File not accounted for in sidebar docs/advanced/es-7-upgrade.md - try adding it to docs-website/sidebars.js

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Excited :)

@jplaisted jplaisted merged commit 5e91014 into master Mar 19, 2021
@jplaisted jplaisted deleted the es-7-support branch March 19, 2021 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants