-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Product Analytics): Introducing In-App Analytics Beta #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -1,2 +1,3 @@ | |||
PUBLIC_URL=/assets | |||
REACT_APP_THEME_CONFIG=theme_light.config.json | |||
SKIP_PREFLIGHT_CHECK=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended?
jjoyce0510
commented
May 7, 2021
.../mae-consumer-job/src/main/java/com/linkedin/metadata/kafka/DataHubUsageEventsProcessor.java
Show resolved
Hide resolved
…nto AnalyticsSprint
…b-fork into AnalyticsSprint
hsheth2
reviewed
May 7, 2021
shirshanka
approved these changes
May 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the reviews @dexter-mh-lee @hsheth2
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the first version of DataHub Product Analytics, it was the result of a design sprint led by the wonderful Maggie Hays @ Spothero!
With this PR, we are happy to introduce a set of analytics that can be found under the "Analytics [beta]" tab at the top of the home page. Currently these include some product analytics and some metadata analytics.
Product Analytics:
Metadata Analytics:
Changes
datahub-frontend
serverdatahub-frontend
which emits to a newly provisioned Kafka topic (DataHubUsageEvents_v1)datahub-frontend
to include 2 new Queries: getAnalyticsCharts and getHighlights.datahub-frontend
to issue analytics queries to ElasticSearch & format responsesThis is a first move on the analytics front, there is still much to do! Please let us know if you'd like to see any specific metrics in the dashboard :)
What it looks like
**
Acknowledgements
Big thanks to Dexter, Gabe, Shirshanka, Harshal & Maggie for the contributions!
Checklist