fix: urlencode slash in urns too #4527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daha
force-pushed
the
urlencode_urn_with_slash
branch
2 times, most recently
from
4d9161f to
85267ed
Compare
|
Looks like there are many flaky tests which fails repeatedly. My guess is that the hard coded ports for docker containers are the problem when other tests using the same containers/ports on the same host. |
daha
force-pushed
the
urlencode_urn_with_slash
branch
2 times, most recently
from
d963bed to
9e7fb9b
Compare
daha
changed the title
Urns for datasources with datasetNameDelimiter: "/" was not encoded correctly, resulting in REST calls not returning any data when querying with the urn.
daha
force-pushed
the
urlencode_urn_with_slash
branch
from
9e7fb9b to
1329123
Compare
|
It might be better to create a urlencode_urn somewhere which run returns urllib.parse.quote(id, safe="") and use that everythere, both in the code and the tests, but I do not know what's the best place to put it. |
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
* fix: urlencode slash in urns too + tests Co-authored-by: Ravindra Lanka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Urns for datasources with datasetNameDelimiter: "/" was not encoded
correctly, resulting in REST calls not returning any data when querying
with the urn.
Checklist