docs: improve versiondropdown design & set docs main to /features #9994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoonhyejin
changed the title
hsheth2
reviewed
Mar 7, 2024
docs-website/docusaurus.config.js
Outdated
| value: '<div style="font-size:0.875rem; padding: 0.25rem 0.5rem;"><b>Archived versions</b></div>', | ||
| }, | ||
| { | ||
| href: "https://docs-website-irpoe2osc-acryldata.vercel.app/docs/features", | ||
| label: "0.11.0", |
There was a problem hiding this comment.
not strictly necessary, but we add a little external link icon
| @@ -45,7 +45,7 @@ module.exports = { | |||
| }, | |||
| items: [ | |||
| { | |||
| to: "docs/", | |||
| to: "docs/features", | |||
There was a problem hiding this comment.
there's a number of other pages where we link to the main docs/ page
it'd be easier to remove the existing page, and change the slug for "docs/features" to be "docs/"
however, I think we need to give the docs/features page a slight UI uplift before elevating it - it just looks slightly less crisp than the current docs/ main page
hsheth2
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
Links to related issues (if applicable)
Tests for the changes have been added/updated (if applicable)
Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub
set docs main page to /features (in the old versions as well)
add "archived versions" and hr to version dropdown
