Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Daytona workspace #1339

Open
Tpuljak opened this issue Nov 14, 2024 · 32 comments
Open

Windows Daytona workspace #1339

Tpuljak opened this issue Nov 14, 2024 · 32 comments
Labels
enhancement New feature or request ⚔️ Quest Tracks quest-bot quests

Comments

@Tpuljak
Copy link
Member

Tpuljak commented Nov 14, 2024

Describe the solution you'd like
We should explore the possibility of running Windows images with Daytona to allow users to create workspaces in a Windows environment. This feature might enable additional native development workflows that can not be ran on Linux.
We should look into https://github.com/dockur/windows as possible images to use.

Additional context
We should first discuss the approach here and outline the necessary changes, if any, needed to make this happen.
@Tpuljak Tpuljak added the enhancement New feature or request label Nov 14, 2024
@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Nov 14, 2024
@quest-bot quest-bot
Copy link

quest-bot bot commented Nov 14, 2024

New Quest! image New Quest!

A new Quest has been launched in @daytonaio’s repo.
Merge a PR that solves this issue to loot the Quest and earn your reward.

Loot of 500 USD has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #1339 to link your PR to this Quest.

Questions? Check out the docs.

👉 If no one is assigned to the issue, you are welcome to embark on the quest and tackle it without confirmation from us. In the event that multiple PRs are made from different people, we will generally accept those with the cleanest code.

@divanshu-go
Copy link
Contributor

@Tpuljak I want to know that how the image that we are currently using Is configured. Is there a seperate repository or docker hub link ?

@Tpuljak
Copy link
Member Author

Tpuljak commented Nov 14, 2024

@divanshu-go the current default image that daytona ships with (daytonaio/workspace-project) is built with the devcontainer definition found here https://github.com/daytonaio/daytona/tree/main/hack/project_image.

@divanshu-go
Copy link
Contributor

what the use of [builder_image/.devcontainer](https://github.com/daytonaio/daytona/tree/main/hack/
then

@divanshu-go
Copy link
Contributor

@divanshu-go the current default image that daytona ships with (daytonaio/workspace-project) is built with the devcontainer definition found here https://github.com/daytonaio/daytona/tree/main/hack/project_image.

@Tpuljak thanks for the information ,
are there any other hacks or workarounds to configure while testing it ?

@Tpuljak
Copy link
Member Author

Tpuljak commented Nov 14, 2024

what the use of [builder_image/.devcontainer](https://github.com/daytonaio/daytona/tree/main/hack/ then

You can ignore that for now.

are there any other hacks or workarounds to configure while testing it ?

No need for hacks.
You can configure the default by running daytona server configure or do it on a per-workspace basis with --custom-image and --custom-image-user (or in the advanced config view) when running daytona create.

@divanshu-go
Copy link
Contributor

@Tpuljak what if we consider using https://mcr.microsoft.com/en-us/catalog?search=window&type=partial rather than https://github.com/dockur/windows

@Tpuljak
Copy link
Member Author

Tpuljak commented Nov 14, 2024

@divanshu-go you're free to suggest any approach that will accomplish the goal of creating a windows-based workspace.

@divanshu-go
Copy link
Contributor

@Tpuljak

we have two options here

1. using one of the official images https://hub.docker.com/r/microsoft/windows

Cons:

Pros:

2. using https://github.com/dockur/windows

Cons:

Pros:

  • allow full control to users

@vishwamartur
Copy link

@quest-bot embark

@quest-bot quest-bot
Copy link

quest-bot bot commented Nov 15, 2024

@vishwamartur has embarked on their Quest. 🗡

  • @vishwamartur has been on GitHub since 2020.
  • They have merged 0 public PRs in that time.
  • Their swords are blessed with HTML and CSS magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

@divanshu-go
Copy link
Contributor

@quest-bot embark

@quest-bot quest-bot
Copy link

quest-bot bot commented Nov 15, 2024

@divanshu-go has embarked on their Quest. 🗡

  • @divanshu-go has been on GitHub since 2024.
  • They have merged 12 public PRs in that time.
  • Their swords are blessed with CSS and JavaScript magic ✨
  • They have contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

@Tpuljak
Copy link
Member Author

Tpuljak commented Nov 15, 2024

  1. using one of the official images https://hub.docker.com/r/microsoft/windows

@divanshu-go, I don't believe that this is a viable options. From what I can see, windows containers aren't meant for this use case but rather only for deployment on Windows Servers.

  1. using https://github.com/dockur/windows

Even though the support is currently lacking for MacOS, I suggest you try this out.
You can create an example repository with a devcontainer configuration that has this (https://github.com/dockur/windows?tab=readme-ov-file#usage-) docker compose set. Then try to run daytona create THAT_REPO and let us know how it goes.
Looking at the compose, Daytona might not even have to do anything special here if it can be fully configured with the devcontainer standard.

@divanshu-go
Copy link
Contributor

divanshu-go commented Nov 15, 2024 •
edited
Loading

@Tpuljak If we go with option 1 of using microsoft images and if we want to test them out on linux or macs , we use setups mentioned here accordingly , https://github.com/StefanScherer/windows-docker-machine?tab=readme-ov-file

using this will enable support on all three OS - linux , mac , windows (might work on home edition if we use WSL)

@Tpuljak
Copy link
Member Author

Tpuljak commented Nov 15, 2024

@Tpuljak If we go with option 1 of using microsoft images and if we want to test them out on linux or macs , we use setups mentioned here accordingly , https://github.com/StefanScherer/windows-docker-machine?tab=readme-ov-file

using this will enable support on all three OS - linux , mac , windows (might work on home edition if we use WSL)

@divanshu-go okay. Please try out both setups yourself and let use know how it goes and what might be the better option in the context of Daytona.

@divanshu-go
Copy link
Contributor

@Tpuljak
image
which image should we use.
progress till now , https://github.com/divanshu-go/windows-dev-container.git

@Tpuljak
Copy link
Member Author

Tpuljak commented Nov 15, 2024

which image should we use.

@divanshu-go use anything you want. Ideally, all of them will work normally.

@divanshu-go
Copy link
Contributor

divanshu-go commented Nov 15, 2024 •
edited
Loading

I meant to say that should we show a option to the user regarding this or whatever we choose ?

@Tpuljak
Copy link
Member Author

Tpuljak commented Nov 15, 2024

I meant to say that should we show a option to the user regarding this or whatever we choose ?

If this can be solved through a devcontainer, there is no need to implement anything in Daytona.

@divanshu-go
Copy link
Contributor

divanshu-go commented Nov 15, 2024 •
edited
Loading

image

PS: it worked in the vscode devcontainers

@divanshu-go
Copy link
Contributor

image

@naaa760
Copy link

naaa760 commented Nov 15, 2024

@quest-bot embark

@quest-bot quest-bot
Copy link

quest-bot bot commented Nov 15, 2024

@naaa760 has embarked on their Quest. 🗡

  • @naaa760 has been on GitHub since 2024.
  • They have merged 3 public PRs in that time.
  • Their swords are blessed with JavaScript and TypeScript magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

@Vivekgaddigi
Copy link

@quest-bot embark

@quest-bot quest-bot
Copy link

quest-bot bot commented Nov 16, 2024

@Vivekgaddigi has embarked on their Quest. 🗡

  • @Vivekgaddigi has been on GitHub since 2022.
  • They have merged 0 public PRs in that time.
  • Their swords are blessed with Shell and Makefile magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

@divanshu-go
Copy link
Contributor

image

vishwamartur added a commit to vishwamartur/daytona that referenced this issue Nov 18, 2024
@vishwamartur
Add support for Windows images in Daytona workspaces
f0a36a8 
Related to daytonaio#1339

Add support for Windows images in Daytona to create workspaces in a Windows environment.

* **Devcontainer Configuration**
  - Add a new feature for Windows images using `ghcr.io/devcontainers/features/windows:1` in `hack/project_image/.devcontainer/devcontainer.json`
  - Update the `overrideFeatureInstallOrder` to include the new Windows feature

* **Server Configuration**
  - Add an option to configure Windows images in the `configureCmd` in `pkg/cmd/server/configure.go`
  - Update the `apiServerConfig` to include Windows image configuration

* **Workspace Creation**
  - Add support for creating workspaces with Windows images in the `CreateCmd` in `pkg/cmd/workspace/create.go`
  - Update the `processPrompting` function to handle Windows image options
  - Add a flag for Windows image support in the workspace creation command

* **Project Configuration**
  - Add logic to handle Windows images in the `GetProjectsCreationDataFromPrompt` function in `pkg/cmd/workspace/util/creation_data.go`
  - Update the `ProjectConfigDefaults` to include Windows image defaults
@vishwamartur vishwamartur mentioned this issue Nov 18, 2024
Closed
vishwamartur added a commit to vishwamartur/daytona that referenced this issue Nov 18, 2024
@vishwamartur
Add support for Windows images in Daytona workspaces
c774502 
Related to daytonaio#1339

Add support for Windows images in Daytona to create workspaces in a Windows environment.

* **Devcontainer Configuration**
  - Add a new feature for Windows images using `ghcr.io/devcontainers/features/windows:1` in `hack/project_image/.devcontainer/devcontainer.json`
  - Update the `overrideFeatureInstallOrder` to include the new Windows feature

* **Server Configuration**
  - Add an option to configure Windows images in the `configureCmd` in `pkg/cmd/server/configure.go`
  - Update the `apiServerConfig` to include Windows image configuration

* **Workspace Creation**
  - Add support for creating workspaces with Windows images in the `CreateCmd` in `pkg/cmd/workspace/create.go`
  - Update the `processPrompting` function to handle Windows image options
  - Add a flag for Windows image support in the workspace creation command

* **Project Configuration**
  - Add logic to handle Windows images in the `GetProjectsCreationDataFromPrompt` function in `pkg/cmd/workspace/util/creation_data.go`
  - Update the `ProjectConfigDefaults` to include Windows image defaults

Signed-off-by: Vishwanath Martur <[email protected]>
@Tpuljak
Copy link
Member Author

Tpuljak commented Nov 19, 2024

@divanshu-go based on the discussion we had in slack, you managed to get a windows-based container running and the next step is to figure out how to get agent ssh server running on windows so we can have it running and connected to the daytona server.

@divanshu-go
Copy link
Contributor

image

@Tpuljak
Copy link
Member Author

Tpuljak commented Nov 19, 2024

@divanshu-go no need for this. If you send me a message on Slack, expect a response there.

If you want to discuss the approach here, which we prefer, you will get a response here.

@Rutik7066
Copy link
Contributor

@quest-bot embark

@quest-bot quest-bot
Copy link

quest-bot bot commented Nov 19, 2024

@Rutik7066 has embarked on their Quest. 🗡

  • @Rutik7066 has been on GitHub since 2019.
  • They have merged 12 public PRs in that time.
  • Their swords are blessed with Dockerfile and JavaScript magic ✨
  • They have contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request ⚔️ Quest Tracks quest-bot quests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Tpuljak @Rutik7066 @vishwamartur @Vivekgaddigi @divanshu-go @naaa760