Add support for Windows images in Daytona workspaces #1346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to daytonaio#1339 Add support for Windows images in Daytona to create workspaces in a Windows environment. * **Devcontainer Configuration** - Add a new feature for Windows images using `ghcr.io/devcontainers/features/windows:1` in `hack/project_image/.devcontainer/devcontainer.json` - Update the `overrideFeatureInstallOrder` to include the new Windows feature * **Server Configuration** - Add an option to configure Windows images in the `configureCmd` in `pkg/cmd/server/configure.go` - Update the `apiServerConfig` to include Windows image configuration * **Workspace Creation** - Add support for creating workspaces with Windows images in the `CreateCmd` in `pkg/cmd/workspace/create.go` - Update the `processPrompting` function to handle Windows image options - Add a flag for Windows image support in the workspace creation command * **Project Configuration** - Add logic to handle Windows images in the `GetProjectsCreationDataFromPrompt` function in `pkg/cmd/workspace/util/creation_data.go` - Update the `ProjectConfigDefaults` to include Windows image defaults Signed-off-by: Vishwanath Martur <[email protected]>
vishwamartur
force-pushed
the
add-windows-support
branch
from
f0a36a8
to
c774502
Compare
|
@vishwamartur submitting untested, unbuildable PRs is not acceptable. I imagine this is something AI generated judging from the PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1339
Add support for Windows images in Daytona to create workspaces in a Windows environment.
Devcontainer Configuration
ghcr.io/devcontainers/features/windows:1inhack/project_image/.devcontainer/devcontainer.jsonoverrideFeatureInstallOrderto include the new Windows featureServer Configuration
configureCmdinpkg/cmd/server/configure.goapiServerConfigto include Windows image configurationWorkspace Creation
CreateCmdinpkg/cmd/workspace/create.goprocessPromptingfunction to handle Windows image optionsProject Configuration
GetProjectsCreationDataFromPromptfunction inpkg/cmd/workspace/util/creation_data.goProjectConfigDefaultsto include Windows image defaults