Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enrich adapter response for UPDATE and SELECT queries #79

Merged
merged 5 commits into from
Jan 7, 2022
Merged

enrich adapter response for UPDATE and SELECT queries #79

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7313336
enirch adapter response for UPDATE and SELECT queries
rjh336 Dec 1, 2021
ec22be9
Merge branch 'dbt-labs:main' into 68_connections_updates
rjh336 Dec 20, 2021
2415739
Merge branch 'dbt-labs:main' into 68_connections_updates
rjh336 Dec 23, 2021
bb3d499
code style change
rjh336 Dec 23, 2021
5df4989
Merge branch 'main' into 68_connections_updates
McKnight-42 Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion dbt/adapters/bigquery/connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,14 +417,26 @@ def execute(
bytes_processed = query_job.total_bytes_processed
message = f'{code} ({self.format_bytes(bytes_processed)} processed)'

elif query_job.statement_type in ['INSERT', 'DELETE', 'MERGE']:
elif query_job.statement_type in ['INSERT', 'DELETE', 'MERGE', 'UPDATE']:
code = query_job.statement_type
num_rows = query_job.num_dml_affected_rows
num_rows_formated = self.format_rows_number(num_rows)
bytes_processed = query_job.total_bytes_processed
processed_bytes = self.format_bytes(bytes_processed)
message = f'{code} ({num_rows_formated} rows, {processed_bytes} processed)'

elif query_job.statement_type == 'SELECT':
conn = self.get_thread_connection()
client = conn.handle
# use anonymous table for num_rows
query_table = client.get_table(query_job.destination)
code = 'SELECT'
num_rows = query_table.num_rows
num_rows_formated = self.format_rows_number(num_rows)
bytes_processed = query_job.total_bytes_processed
processed_bytes = self.format_bytes(bytes_processed)
message = f'{code} ({num_rows_formated} rows, {processed_bytes} processed)'

response = BigQueryAdapterResponse(
_message=message,
rows_affected=num_rows,
Expand Down