Add subscribeMailbox to Connection
#581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #581 +/- ##
============================================
+ Coverage 95.69% 95.71% +0.01%
- Complexity 363 365 +2
============================================
Files 45 45
Lines 930 933 +3
============================================
+ Hits 890 893 +3
Misses 40 40 ☔ View full report in Codecov by Sentry. |
|
Hi, so what's missing here, I guess it has something to do with tests? |
|
Tests are indeed missing. Once you added them, please run: make start-imap-server
make |
|
Hi @Slamdunk thanks for following up. Next I ran into the docker image not having the php-imap extension installed. managed to install it but finally gave up because although installed it was reporting that it was not enabled.... So after two hours of fiddling around, I can at least tell you that if the test code I added was succesfull I wouldn't trust it being actual successfull :)) In short: I gave up. I have updated the PR with the testcode I produced: hope it helps and also hope my feedback helps to get this docker thing working correct on noob setups. This is as much I as I can do to contribute |
Not sure why this happens for you, but This is the output of the two commands so you can compare them to yours:
|
|
just to follow up: then the sudo make gives the following error: As said, I am not versed enough (nor have the time available) to learn the ins-and-outs of docker: so this is not going to work for me. Probably best to test the PR yourself. Or not accept it > not to keen on running my own fork, but that would also be an option for me. Anyway hope this helps! |
|
I see that |
|
Hi that was the first change I made yesterday , first of many changes needed after that: see #581 (comment) where I already mention having replaced that environment variable. Anyway, I think the 'issue' was in the codestyle for the {} on the exception I created. Fixed that so lets see if it will run correct now |
Slamdunk
changed the title
subscribeMailbox to Connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So just ran into the same 'issue' as here: #448 and thought why not create a PR for it: first PR on this repo so hope it is okay or otherwise would love some feedback on what to change / improve.
I have added subscribeMailbox as a separate method and not as part of the createMailbox method as I am not sure if all IMAP servers support subscribing.
Having it as a separate function gives more flexibility.