Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQLite DB ENV variables for simpletest. #6

Closed
wants to merge 3 commits into from
Closed

Add SQLite DB ENV variables for simpletest. #6

wants to merge 3 commits into from

Conversation

bhanu951
Copy link

@bhanu951 bhanu951 commented Dec 4, 2022

Fixes #5

@weitzman
Copy link
Collaborator

weitzman commented Dec 4, 2022

Can you say a bit about why this is needed? You can override SIMPLETEST_DB in your DDEV config.

@bhanu951
Copy link
Author

bhanu951 commented Dec 4, 2022

Can you say a bit about why this is needed? You can override SIMPLETEST_DB in your DDEV config.

Hi @weitzman

I tried to override SIMPLETEST_DB env variable in config.yml as below

composer_version: "2"
web_environment:
- SIMPLETEST_DB=sqlite://tmp/sites/simpletest/db.sqlite
nodejs_version: "16"

but it has not overrided the value defined in docker-compose.selenium-chrome.yaml do you have any suggestion on how to handle it ?

@weitzman
Copy link
Collaborator

weitzman commented Dec 4, 2022

Hmm, IMO that should work. I would have thought that config.yml overrides config copied from a docker-compose file. Maybe @rfay has insight?

If config.yml override is not possible, I think we should only define these vars during our tests and expect users to set them in config.yml. Thats a bit more work and opportunity to struggle but c'est la vie.

@rfay
Copy link
Member

rfay commented Dec 4, 2022

docker-compose.*.yaml will win, I think.

The environment variables would be better set in a config.selenium-standalone-chrome.yaml I think, would give people more control?

@bhanu951 you should be able to override them with another docker-compose.*.yaml, maybe docker-compose.z.yaml or even docker-compose.override.yaml which very few people ever use.

But I do think the better change would be to move these to config.selenium-standalone-chrome.yaml.

@weitzman weitzman mentioned this pull request Dec 4, 2022
@weitzman
Copy link
Collaborator

weitzman commented Dec 4, 2022

Closed in favor of #7

@weitzman weitzman closed this Dec 4, 2022
@bhanu951 bhanu951 deleted the feature/add-sqlite-env-variables branch December 5, 2022 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SQLite DB ENV Variables for simpletest
3 participants