Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to a config file. #7

Merged
merged 5 commits into from
Dec 4, 2022
Merged

Move to a config file. #7

merged 5 commits into from
Dec 4, 2022

Conversation

weitzman
Copy link
Collaborator

@weitzman weitzman commented Dec 4, 2022

Fixes #5,#6

rfay
rfay requested changes Dec 4, 2022
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this should be more flexible. I hope.

config.selenium-standalone-chrome.yaml Show resolved Hide resolved
@rfay
Copy link
Member

rfay commented Dec 4, 2022

Oh, I see the docker-compose is also missing the #ddev-generated - without that ddev get will be unwilling to override when executed again.

@weitzman weitzman merged commit a7c8e2d into main Dec 4, 2022
@weitzman weitzman deleted the move-config branch December 4, 2022 16:06
@weitzman weitzman mentioned this pull request Dec 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfay rfay rfay requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SQLite DB ENV Variables for simpletest
2 participants
@weitzman @rfay