CP-6621 bump sdk version to 4.0.0 #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrburke
requested review from
ankursarin,
mothslaw and
nhlien93
as code owners
mothslaw
approved these changes
Nov 19, 2021
Comment on lines
12
to
14
| def test_get_version(): | ||
| assert package_util.get_version() == '3.2.0.dev0' | ||
| assert package_util.get_version() == '4.0.0.dev0' | ||
|
|
There was a problem hiding this comment.
There is no need to do anything about this comment with this diff... but I wanted to raise a question for everyone...
Does this test have any utility whatsoever?
The existence of this test means the the developer workflow is often
- Bump the version
- Run unit tests
- "Oh crap, I forgot, I also have to go and manually change that one test, too"
- Change this test
- Run unit tests again
I could be missing something, but steps (3-5) feel like unnecessary "makework". It doesn't seem like this test is actually protecting us against anything, and so we could delete it, and make the release bump process smoother.
There was a problem hiding this comment.
I think it helps make sure someone did not update the version accidentally?
There was a problem hiding this comment.
I guess, but it seems like code reviews should handle that...
Or maybe the test could be modified to only check the "number" part of the version? Like, it probably matters that we don't accidentally move to 4.1.0. But, if the dev part changes, that's probably not anything we need to test for, right?
Not a huge deal to me. Just thought I'd bring it up for discussion.
ankursarin
approved these changes
Nov 19, 2021
mrburke
pushed a commit
that referenced
this pull request
Jan 12, 2022
* DOC-1074 Document password vault support for VSDK plugins (#347) * Correct Typo in Example, it should be UNIX not WINDOWS (#360) * Add documentation for gRPC message and memory limits #390 (#391) * Fix version number in doc header (#358) (#397) * Update Delphix Engine version required to 6.0.7.0. (#386) (#398) * Update SDK Docs deployment to use a deploy_key (#392) (#399) * CP-6005 Ensure vSDK test coverage (#403) * CP-6006 Futurize vSDK - Stage 1 (#404) * Add support for virtualCleanup decorator (#400) (#405) Co-authored-by: Kurt Hutchison <[email protected]> * Fixes #401 Networking capabilities should be documented (#402) Fixes #401 Networking capabilities should be documented * CP-6009 Add to_str and to_byte helpers (#407) * CP-6621 bump sdk version to 4.0.0 (#409) * CP-6694 Update docs for SDK 4.0.0 (#410) * CP-7022 vSDK 4.0.0 release tasks * Update VirtualDelete flow diagram to include the virtual.cleanup call. (#414) Co-authored-by: Kurt Hutchison <[email protected]> * Update documentation with new gRPC message limits (#415) Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]>
mrburke
pushed a commit
to mrburke/virtualization-sdk
that referenced
this pull request
Jan 13, 2022
* DOC-1074 Document password vault support for VSDK plugins (delphix#347) * Correct Typo in Example, it should be UNIX not WINDOWS (delphix#360) * Add documentation for gRPC message and memory limits delphix#390 (delphix#391) * Fix version number in doc header (delphix#358) (delphix#397) * Update Delphix Engine version required to 6.0.7.0. (delphix#386) (delphix#398) * Update SDK Docs deployment to use a deploy_key (delphix#392) (delphix#399) * CP-6005 Ensure vSDK test coverage (delphix#403) * CP-6006 Futurize vSDK - Stage 1 (delphix#404) * Add support for virtualCleanup decorator (delphix#400) (delphix#405) Co-authored-by: Kurt Hutchison <[email protected]> * Fixes delphix#401 Networking capabilities should be documented (delphix#402) Fixes delphix#401 Networking capabilities should be documented * CP-6009 Add to_str and to_byte helpers (delphix#407) * CP-6621 bump sdk version to 4.0.0 (delphix#409) * CP-6694 Update docs for SDK 4.0.0 (delphix#410) * CP-7022 vSDK 4.0.0 release tasks * Update VirtualDelete flow diagram to include the virtual.cleanup call. (delphix#414) Co-authored-by: Kurt Hutchison <[email protected]> * Update documentation with new gRPC message limits (delphix#415) Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]>
mrburke
pushed a commit
that referenced
this pull request
Jan 13, 2022
* DOC-1074 Document password vault support for VSDK plugins (#347) * Correct Typo in Example, it should be UNIX not WINDOWS (#360) * Add documentation for gRPC message and memory limits #390 (#391) * Fix version number in doc header (#358) (#397) * Update Delphix Engine version required to 6.0.7.0. (#386) (#398) * Update SDK Docs deployment to use a deploy_key (#392) (#399) * CP-6005 Ensure vSDK test coverage (#403) * CP-6006 Futurize vSDK - Stage 1 (#404) * Add support for virtualCleanup decorator (#400) (#405) Co-authored-by: Kurt Hutchison <[email protected]> * Fixes #401 Networking capabilities should be documented (#402) Fixes #401 Networking capabilities should be documented * CP-6009 Add to_str and to_byte helpers (#407) * CP-6621 bump sdk version to 4.0.0 (#409) * CP-6694 Update docs for SDK 4.0.0 (#410) * CP-7022 vSDK 4.0.0 release tasks * Update VirtualDelete flow diagram to include the virtual.cleanup call. (#414) Co-authored-by: Kurt Hutchison <[email protected]> * Update documentation with new gRPC message limits (#415) Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]> Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]>
mrburke
pushed a commit
that referenced
this pull request
Jan 20, 2022
* CP-7022 vSDK 4.0.0 release tasks (#416) * Bumping sdk to 4.0.2 and dvp-api to 1.6.3 due to bad upload of dvp-api 1.6.1 to pypi (#419) * Release (#418) * DOC-1074 Document password vault support for VSDK plugins (#347) * Correct Typo in Example, it should be UNIX not WINDOWS (#360) * Add documentation for gRPC message and memory limits #390 (#391) * Fix version number in doc header (#358) (#397) * Update Delphix Engine version required to 6.0.7.0. (#386) (#398) * Update SDK Docs deployment to use a deploy_key (#392) (#399) * CP-6005 Ensure vSDK test coverage (#403) * CP-6006 Futurize vSDK - Stage 1 (#404) * Add support for virtualCleanup decorator (#400) (#405) Co-authored-by: Kurt Hutchison <[email protected]> * Fixes #401 Networking capabilities should be documented (#402) Fixes #401 Networking capabilities should be documented * CP-6009 Add to_str and to_byte helpers (#407) * CP-6621 bump sdk version to 4.0.0 (#409) * CP-6694 Update docs for SDK 4.0.0 (#410) * CP-7022 vSDK 4.0.0 release tasks * Update VirtualDelete flow diagram to include the virtual.cleanup call. (#414) Co-authored-by: Kurt Hutchison <[email protected]> * Update documentation with new gRPC message limits (#415) Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]> * Release (#418) (#421) * DOC-1074 Document password vault support for VSDK plugins (#347) * Correct Typo in Example, it should be UNIX not WINDOWS (#360) * Add documentation for gRPC message and memory limits #390 (#391) * Fix version number in doc header (#358) (#397) * Update Delphix Engine version required to 6.0.7.0. (#386) (#398) * Update SDK Docs deployment to use a deploy_key (#392) (#399) * CP-6005 Ensure vSDK test coverage (#403) * CP-6006 Futurize vSDK - Stage 1 (#404) * Add support for virtualCleanup decorator (#400) (#405) Co-authored-by: Kurt Hutchison <[email protected]> * Fixes #401 Networking capabilities should be documented (#402) Fixes #401 Networking capabilities should be documented * CP-6009 Add to_str and to_byte helpers (#407) * CP-6621 bump sdk version to 4.0.0 (#409) * CP-6694 Update docs for SDK 4.0.0 (#410) * CP-7022 vSDK 4.0.0 release tasks * Update VirtualDelete flow diagram to include the virtual.cleanup call. (#414) Co-authored-by: Kurt Hutchison <[email protected]> * Update documentation with new gRPC message limits (#415) Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]> Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]> Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The move to support Python3 is a breaking change (CLI will not work with py2), as such as we should bump the major version
This diff is automated, I just ran
bumpversion major