Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-6621 bump sdk version to 4.0.0 #409

Merged
merged 1 commit into from
Nov 19, 2021
Merged

CP-6621 bump sdk version to 4.0.0 #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .bumpversion.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
[bumpversion]
current_version = 3.2.0.dev0
current_version = 4.0.0.dev0
commit = False
tag = False
parse = (?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)(\.(?P<release>[a-z]+)(?P<dev>\d+))?
serialize =
serialize =
{major}.{minor}.{patch}.{release}{dev}
{major}.{minor}.{patch}

[bumpversion:part:release]
optional_value = prod
first_value = dev
values =
values =
dev
prod

Expand Down
2 changes: 1 addition & 1 deletion common/src/main/python/dlpx/virtualization/common/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.2.0.dev0
4.0.0.dev0
2 changes: 1 addition & 1 deletion dvp/src/main/python/dlpx/virtualization/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.2.0.dev0
4.0.0.dev0
2 changes: 1 addition & 1 deletion libs/src/main/python/dlpx/virtualization/libs/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.2.0.dev0
4.0.0.dev0
2 changes: 1 addition & 1 deletion platform/src/main/python/dlpx/virtualization/platform/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.2.0.dev0
4.0.0.dev0
2 changes: 1 addition & 1 deletion tools/src/main/python/dlpx/virtualization/_internal/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.2.0.dev0
4.0.0.dev0
2 changes: 1 addition & 1 deletion tools/src/test/python/dlpx/virtualization/_internal/test_package_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
class TestPackageUtil:
@staticmethod
def test_get_version():
assert package_util.get_version() == '3.2.0.dev0'
assert package_util.get_version() == '4.0.0.dev0'

Comment on lines 12 to 14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to do anything about this comment with this diff... but I wanted to raise a question for everyone...

Does this test have any utility whatsoever?

The existence of this test means the the developer workflow is often

  1. Bump the version
  2. Run unit tests
  3. "Oh crap, I forgot, I also have to go and manually change that one test, too"
  4. Change this test
  5. Run unit tests again

I could be missing something, but steps (3-5) feel like unnecessary "makework". It doesn't seem like this test is actually protecting us against anything, and so we could delete it, and make the release bump process smoother.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it helps make sure someone did not update the version accidentally?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, but it seems like code reviews should handle that...

Or maybe the test could be modified to only check the "number" part of the version? Like, it probably matters that we don't accidentally move to 4.1.0. But, if the dev part changes, that's probably not anything we need to test for, right?

Not a huge deal to me. Just thought I'd bring it up for discussion.

@staticmethod
def test_get_virtualization_api_version():
Expand Down